status-im
/
status-desktop
mirror of https://github.com/status-im/status-desktop.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(@desktop/chat): fix sticker/image notification with placeholder 

fixes #2450
This commit is contained in:
Anthony Laibe 2021-07-14 11:22:00 +02:00 committed by Iuri Matias
parent d866a9f59e
commit 511c959121
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/app/chat/views/messages.nim
View File

@ -223,7 +223,7 @@ QtObject:
proc isAddedContact*(self: MessageView, id: string): bool {.slot.} = proc isAddedContact*(self: MessageView, id: string): bool {.slot.} =
result = self.status.contacts.isAdded(id) result = self.status.contacts.isAdded(id)
proc messageNotificationPushed*(self: MessageView, chatId: string, text: string, messageType: string, chatType: int, timestamp: string, identicon: string, username: string, hasMention: bool, isAddedContact: bool, channelName: string) {.signal.} proc messageNotificationPushed*(self: MessageView, chatId: string, text: string, contentType: int, chatType: int, timestamp: string, identicon: string, username: string, hasMention: bool, isAddedContact: bool, channelName: string) {.signal.}
proc pushMessages*(self:MessageView, messages: var seq[Message]) = proc pushMessages*(self:MessageView, messages: var seq[Message]) =
for msg in messages.mitems: for msg in messages.mitems:
@ -259,7 +259,7 @@ QtObject:
if not channel.muted: if not channel.muted:
let isAddedContact = channel.chatType.isOneToOne and self.isAddedContact(channel.id) let isAddedContact = channel.chatType.isOneToOne and self.isAddedContact(channel.id)
if msg.editedAt == "0": # Do not push notifications for edit messages if msg.editedAt == "0": # Do not push notifications for edit messages
self.messageNotificationPushed(msg.chatId, escape_html(msg.text), msg.messageType, channel.chatType.int, msg.timestamp, msg.identicon, msg.userName, msg.hasMention, isAddedContact, channel.name) self.messageNotificationPushed(msg.chatId, escape_html(msg.text), msg.contentType.int, channel.chatType.int, msg.timestamp, msg.identicon, msg.userName, msg.hasMention, isAddedContact, channel.name)
proc markMessageAsSent*(self:MessageView, chat: string, messageId: string) = proc markMessageAsSent*(self:MessageView, chat: string, messageId: string) =
if self.messageList.contains(chat): if self.messageList.contains(chat):

7
ui/app/AppLayouts/Chat/ChatColumn/ChatMessages.qml
View File

@ -206,8 +206,9 @@ SplitView {
} }
} }
onMessageNotificationPushed: function(chatId, msg, messageType, chatType, timestamp, identicon, username, hasMention, isAddedContact, channelName) { onMessageNotificationPushed: function(chatId, msg, contentType, chatType, timestamp, identicon, username, hasMention, isAddedContact, channelName) {
if (messageType == Constants.editType) return; if (contentType == Constants.editType) return;
if (appSettings.notificationSetting == Constants.notifyAllMessages || if (appSettings.notificationSetting == Constants.notifyAllMessages ||
(appSettings.notificationSetting == Constants.notifyJustMentions && hasMention)) { (appSettings.notificationSetting == Constants.notifyJustMentions && hasMention)) {
if (chatId === chatsModel.channelView.activeChannel.id && applicationWindow.active === true) { if (chatId === chatsModel.channelView.activeChannel.id && applicationWindow.active === true) {
@ -229,7 +230,7 @@ SplitView {
let message; let message;
if (appSettings.notificationMessagePreviewSetting > Constants.notificationPreviewNameOnly) { if (appSettings.notificationMessagePreviewSetting > Constants.notificationPreviewNameOnly) {
switch(messageType){ switch(contentType){
//% "Image" //% "Image"
case Constants.imageType: message = qsTrId("image"); break case Constants.imageType: message = qsTrId("image"); break
//% "Sticker" //% "Sticker"