From 4f09a399298ec00321b4b29cb1cf24e0964890f3 Mon Sep 17 00:00:00 2001 From: Iuri Matias Date: Mon, 9 Sep 2024 11:19:56 -0400 Subject: [PATCH] chore: update pr template --- .github/pull_request_template.md | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index d2f634798f..74b25281c1 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -6,6 +6,19 @@ +### Developer Checklist + +#### Tests & QA +- [ ] I have created user stories for this feature/rework +- [ ] I have written unit tests for status-go and QML changes +- [ ] I have created a storybook page for all UI components and views +- [ ] I have tested this PR on both storybook and the actual client (for UI changes) +- [ ] I have followed the architecture guidelines: [Architecture guidelines](../architecture-guide.md) +- [ ] For bug fixes, I have written a new unit test case to prevent reintroduction +- [ ] I have performed side impact testing for changes in shared components +- [ ] A reviewer has Tested the PR during review +- [ ] Given enough time for a thorough review + ### Architecture compliance - [ ] I am familiar with the application architecture and agreed good practices. @@ -17,6 +30,11 @@ My PR is consistent with this document: [Architecture guidelines](../architectur +### QA Testing Requirements + +- [ ] This PR requires QA testing for the entire user story +- [ ] This PR is a bug fix and can rely on dev + reviewer testing +