status-im/status-desktop
2
0
Fork 0
mirror of https://github.com/status-im/status-desktop.git synced 2025-01-11 14:54:48 +00:00
Code Issues Projects Releases Wiki Activity

fix(@desktop/wallet): app crash when signing token transaction with invalid password

Browse Source 
The issue was accessing non existent property after parsing received response. That caused
app crash, fixed now.

Fixes: #2623
This commit is contained in:
Sale Djenic 2021-07-07 12:09:45 +02:00 committed by Iuri Matias
parent 3bb5be8685
commit 4d148b5c78
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/app/wallet/views/transactions.nim
View File

@ -134,8 +134,8 @@ QtObject:
discard self.status.wallet.checkRecentHistory(addresses) discard self.status.wallet.checkRecentHistory(addresses)
proc transactionWatchResultReceived(self: TransactionsView, watchResult: string) {.slot.} = proc transactionWatchResultReceived(self: TransactionsView, watchResult: string) {.slot.} =
let wTxRes = watchResult.parseJSON()["result"].getStr().parseJson(){"result"} let wTxRes = watchResult.parseJSON()
if wTxRes.kind == JNull: if not wTxRes.contains("result"):
self.checkRecentHistory() self.checkRecentHistory()
else: else:
discard #TODO: Ask Simon if should we show an error popup indicating the trx wasn't mined in 10m or something discard #TODO: Ask Simon if should we show an error popup indicating the trx wasn't mined in 10m or something