From 4cda8d883544eaea9edd7a32fe9a8b360cc8c24e Mon Sep 17 00:00:00 2001 From: Richard Ramos Date: Wed, 2 Feb 2022 09:37:40 -0400 Subject: [PATCH] fix: code review --- src/app/modules/main/communities/controller.nim | 4 ---- src/app_service/service/community/service.nim | 8 -------- 2 files changed, 12 deletions(-) diff --git a/src/app/modules/main/communities/controller.nim b/src/app/modules/main/communities/controller.nim index a90941f810..8248d7086f 100644 --- a/src/app/modules/main/communities/controller.nim +++ b/src/app/modules/main/communities/controller.nim @@ -51,10 +51,6 @@ method init*(self: Controller) = method getAllCommunities*(self: Controller): seq[CommunityDto] = result = self.communityService.getAllCommunities() - self.events.on(SIGNAL_COMMUNITY_CATEGORY_REORDERED) do(e:Args): - let args = CommunityCategoryOrderArgs(e) - # self.delegate.communityCategoryReordered() - method joinCommunity*(self: Controller, communityId: string): string = self.communityService.joinCommunity(communityId) diff --git a/src/app_service/service/community/service.nim b/src/app_service/service/community/service.nim index c14c348e05..33a8cd04d1 100644 --- a/src/app_service/service/community/service.nim +++ b/src/app_service/service/community/service.nim @@ -72,7 +72,6 @@ const SIGNAL_COMMUNITY_CHANNEL_DELETED* = "communityChannelDeleted" const SIGNAL_COMMUNITY_CATEGORY_CREATED* = "communityCategoryCreated" const SIGNAL_COMMUNITY_CATEGORY_EDITED* = "communityCategoryEdited" const SIGNAL_COMMUNITY_CATEGORY_DELETED* = "communityCategoryDeleted" -const SIGNAL_COMMUNITY_CATEGORY_REORDERED* = "communityCategoryReordered" const SIGNAL_COMMUNITY_MEMBER_APPROVED* = "communityMemberApproved" QtObject: @@ -660,13 +659,6 @@ QtObject: let error = Json.decode($response.error, RpcError) raise newException(RpcException, "Error reordering community category: " & error.message) - self.events.emit(SIGNAL_COMMUNITY_CATEGORY_REORDERED, - CommunityCategoryOrderArgs( - communityId: communityId, - categoryId: categoryId, - position: position - ) - ) except Exception as e: error "Error reordering category channel", msg = e.msg, communityId, categoryId, position