status-im/status-desktop
2
0
Fork 0
mirror of https://github.com/status-im/status-desktop.git synced 2025-02-03 02:06:19 +00:00
Code Issues Projects Releases Wiki Activity

fix(@desktop/activity): Fixed section glitch (#10576)

Browse Source 
fixes #10472
This commit is contained in:
Cuteivist 2023-05-09 10:05:03 +02:00 committed by GitHub
parent 190e903921
commit 461f4a2bee
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ui/imports/shared/views/HistoryView.qml
View File

@ -138,6 +138,7 @@ ColumnLayout {
ScrollBar.vertical: StatusScrollBar {} ScrollBar.vertical: StatusScrollBar {}
section.property: "date" section.property: "date"
topMargin: -20 // Top margin for first section. Section cannot have different sizes
section.delegate: ColumnLayout { section.delegate: ColumnLayout {
id: sectionDelegate id: sectionDelegate
@ -145,21 +146,23 @@ ColumnLayout {
width: ListView.view.width width: ListView.view.width
// display always first section. Other sections when more items are being fetched must not be visible // display always first section. Other sections when more items are being fetched must not be visible
visible: isFirstSection || section.length > 1 // 1 because we don't use empty for loading state
// Additionaly height must be defined so all sections use same height to to glitch sections when updating model
height: isFirstSection || section.length > 1 ? 58 : 0
visible: height > 0 // display always first section. Other sections when more items are being fetched must not be visible
spacing: 0 spacing: 0
required property string section required property string section
Separator { Separator {
Layout.fillWidth: true Layout.fillWidth: true
Layout.topMargin: sectionDelegate.isFirstSection ? 0 : 20 Layout.topMargin: 20
implicitHeight: 1 implicitHeight: 1
} }
StatusTextWithLoadingState { StatusTextWithLoadingState {
id: sectionText id: sectionText
Layout.alignment: Qt.AlignBottom
Layout.topMargin: 12
leftPadding: 16 leftPadding: 16
bottomPadding: 8 bottomPadding: 8
text: loading ? "dummy" : parent.section // dummy text because loading component height depends on text height, and not visible with height == 0 text: loading ? "dummy" : parent.section // dummy text because loading component height depends on text height, and not visible with height == 0