status-im
/
status-desktop
mirror of https://github.com/status-im/status-desktop.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(@desktop/chat): app crash when you click macOS' notification 

A crash is happening not only when you click on a notification bubble with mentions, but on any
chat notification displayed in macOS' notification center. Discussion and details how we can
overcome this may be seen on zenhub, in issue 2819. So far this commit is just a simple solution
to avoid an app crash.

Fixes: #2819
This commit is contained in:
Sale Djenic 2021-07-09 09:49:08 +02:00 committed by Iuri Matias
parent 621f723ecf
commit 4207844826
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ui/app/AppLayouts/Chat/ChatColumn.qml
View File

@ -199,15 +199,14 @@ StackLayout {
}
function clickOnNotification() {
// So far we're just showing this app as the top most window. Once we decide about the way
// how to notify the app what channle should be displayed within the app when user clicks
// notificaiton bubble this part should be updated accordingly.
//
// I removed part of this function which caused app crash.
applicationWindow.show()
applicationWindow.raise()
applicationWindow.requestActivate()
appMain.changeAppSection(Constants.chat)
if (currentNotificationChatId) {
chatsModel.channelView.setActiveChannel(currentNotificationChatId)
} else if (currentNotificationCommunityId) {
chatsModel.communities.setActiveCommunity(currentNotificationCommunityId)
}
}
Connections {