From 3c4eb3180d4cd7fc2b268df0ac2a878b72fd1ad8 Mon Sep 17 00:00:00 2001 From: Anastasiya Semenkevich Date: Fri, 30 Aug 2024 10:04:52 +0300 Subject: [PATCH] tests: fix typo in method name and update PRs tests list --- .../tests/communities/test_communities_channels.py | 2 +- ...estart.py => test_add_account_after_restart.py} | 0 ...py => test_add_delete_account_from_settings.py} | 1 - .../test_add_edit_delete_generated_account.py | 1 + .../test_onboarding_import_seed.py | 14 +++++++------- 5 files changed, 9 insertions(+), 9 deletions(-) rename test/e2e/tests/crtitical_tests_prs/{test_plus_button_add_account_after_restart.py => test_add_account_after_restart.py} (100%) rename test/e2e/tests/crtitical_tests_prs/{test_wallet_settings_acct_interactions_delete_account.py => test_add_delete_account_from_settings.py} (99%) rename test/e2e/tests/{wallet_main_screen/wallet - plus button => crtitical_tests_prs}/test_add_edit_delete_generated_account.py (99%) diff --git a/test/e2e/tests/communities/test_communities_channels.py b/test/e2e/tests/communities/test_communities_channels.py index 00ab326873..4dc67ae118 100644 --- a/test/e2e/tests/communities/test_communities_channels.py +++ b/test/e2e/tests/communities/test_communities_channels.py @@ -114,7 +114,7 @@ def test_member_role_cannot_add_edit_and_delete_channels(main_screen: MainWindow with step('Open context menu from the tool bar'): more_options = community_screen.tool_bar.open_more_options_dropdown() with step('Verify that edit item is not present in context menu'): - assert more_options.iedit_channel_from_context.exists is False, \ + assert more_options.edit_channel_from_context.exists is False, \ f'Edit channel option is present when it should not' with step('Verify that delete item is not present in context menu'): assert more_options.delete_channel_from_context.exists is False, \ diff --git a/test/e2e/tests/crtitical_tests_prs/test_plus_button_add_account_after_restart.py b/test/e2e/tests/crtitical_tests_prs/test_add_account_after_restart.py similarity index 100% rename from test/e2e/tests/crtitical_tests_prs/test_plus_button_add_account_after_restart.py rename to test/e2e/tests/crtitical_tests_prs/test_add_account_after_restart.py diff --git a/test/e2e/tests/crtitical_tests_prs/test_wallet_settings_acct_interactions_delete_account.py b/test/e2e/tests/crtitical_tests_prs/test_add_delete_account_from_settings.py similarity index 99% rename from test/e2e/tests/crtitical_tests_prs/test_wallet_settings_acct_interactions_delete_account.py rename to test/e2e/tests/crtitical_tests_prs/test_add_delete_account_from_settings.py index b732b475be..96b2bdb03f 100644 --- a/test/e2e/tests/crtitical_tests_prs/test_wallet_settings_acct_interactions_delete_account.py +++ b/test/e2e/tests/crtitical_tests_prs/test_add_delete_account_from_settings.py @@ -30,7 +30,6 @@ pytestmark = marks string.digits, k=15)), '#2a4af5', 'sunglasses', '1f60e') ]) -@pytest.mark.critical def test_delete_generated_account_from_wallet_settings( main_screen: MainWindow, user_account, account_name: str, color: str, emoji: str, emoji_unicode: str): with step('Open add account pop up from wallet settings'): diff --git a/test/e2e/tests/wallet_main_screen/wallet - plus button/test_add_edit_delete_generated_account.py b/test/e2e/tests/crtitical_tests_prs/test_add_edit_delete_generated_account.py similarity index 99% rename from test/e2e/tests/wallet_main_screen/wallet - plus button/test_add_edit_delete_generated_account.py rename to test/e2e/tests/crtitical_tests_prs/test_add_edit_delete_generated_account.py index cef112622d..f31c801c0d 100644 --- a/test/e2e/tests/wallet_main_screen/wallet - plus button/test_add_edit_delete_generated_account.py +++ b/test/e2e/tests/crtitical_tests_prs/test_add_edit_delete_generated_account.py @@ -25,6 +25,7 @@ pytestmark = marks pytest.param('#2a4af5', 'sunglasses', '1f60e', '#216266', 'thumbsup', '1f44d') ]) +@pytest.mark.critical def test_add_edit_delete_generated_account(main_screen: MainWindow, user_account, color: str, emoji: str, emoji_unicode: str, new_color: str, new_emoji: str, diff --git a/test/e2e/tests/crtitical_tests_prs/test_onboarding_import_seed.py b/test/e2e/tests/crtitical_tests_prs/test_onboarding_import_seed.py index 0d74fcbc87..84654db903 100644 --- a/test/e2e/tests/crtitical_tests_prs/test_onboarding_import_seed.py +++ b/test/e2e/tests/crtitical_tests_prs/test_onboarding_import_seed.py @@ -4,6 +4,7 @@ from allure_commons._allure import step from constants import ReturningUser, ReturningUsersData from constants.onboarding import KeysExistText +from constants.wallet import WalletNetworkSettings from driver.aut import AUT from tests.onboarding import marks @@ -32,13 +33,12 @@ def keys_screen(main_window) -> KeysView: @pytest.mark.parametrize('user_account', [ReturningUser( seed_phrase=ReturningUsersData.RETURNING_USER_ONE.value[0], status_address=ReturningUsersData.RETURNING_USER_ONE.value[1])]) -@pytest.mark.parametrize('autocomplete, default_name', [ - pytest.param(True, 'Account 1', marks=pytest.mark.critical) -]) -def test_import_seed_phrase(keys_screen, main_window, aut: AUT, user_account, default_name: str, autocomplete: bool): +@pytest.mark.critical +# TODO: change to use random seeds in onboarding after https://github.com/status-im/status-desktop/issues/16216 is fixed +def test_import_seed_phrase(keys_screen, main_window, aut: AUT, user_account): with step('Open import seed phrase view and enter seed phrase'): input_view = keys_screen.open_import_seed_phrase_view().open_seed_phrase_input_view() - input_view.input_seed_phrase(user_account.seed_phrase, autocomplete) + input_view.input_seed_phrase(user_account.seed_phrase, autocomplete=True) profile_view = input_view.import_seed_phrase() profile_view.set_display_name(user_account.name) @@ -59,7 +59,7 @@ def test_import_seed_phrase(keys_screen, main_window, aut: AUT, user_account, de with (step('Verify that restored account reveals correct status wallet address')): status_account_index = 0 status_acc_view = ( - LeftPanel().open_settings().left_panel.open_wallet_settings().open_account_in_settings(default_name, + LeftPanel().open_settings().left_panel.open_wallet_settings().open_account_in_settings(WalletNetworkSettings.STATUS_ACCOUNT_DEFAULT_NAME.value, status_account_index)) address = status_acc_view.get_account_address_value() assert address == user_account.status_address, \ @@ -73,7 +73,7 @@ def test_import_seed_phrase(keys_screen, main_window, aut: AUT, user_account, de with step('Restart application and try re-importing seed phrase again'): aut.restart() enter_seed_view = LoginView().add_existing_status_user().open_keys_view().open_enter_seed_phrase_view() - enter_seed_view.input_seed_phrase(user_account.seed_phrase, autocomplete) + enter_seed_view.input_seed_phrase(user_account.seed_phrase, autocomplete=False) confirm_import = enter_seed_view.click_import_seed_phrase_button() with step('Verify that keys already exist popup appears and text is correct'):