status-im
/
status-desktop
mirror of https://github.com/status-im/status-desktop.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(profile): fix missing ring in own profile (#15366) 

Fixes #15314

The problem is that we used the `name` property to know if we have an ENS name, but we actually set it to whatever is available, so we need to validate that it's an ENS name
This commit is contained in:
Jonathan Rainville 2024-07-03 14:06:03 -04:00 committed by GitHub
parent dc554f8ea2
commit 393ee8e284
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
storybook/qmlTests/tests/tst_ContactDetails.qml
View File

@ -108,7 +108,7 @@ Item {
compare(contactDetails.profileStore.displayName,"myDisplayName", "Expected the profile store to be set") compare(contactDetails.profileStore.displayName,"myDisplayName", "Expected the profile store to be set")
compare(contactDetails.displayName, contactDetails.profileStore.displayName, "Expected the display name to be set") compare(contactDetails.displayName, contactDetails.profileStore.displayName, "Expected the display name to be set")
compare(contactDetails.ensName, contactDetails.profileStore.name, "Expected the ens name to be set") compare(contactDetails.ensName, contactDetails.profileStore.name, "Expected the ens name to be set")
compare(contactDetails.ensVerified, true, "Expected the ensVerified to be set") compare(contactDetails.ensVerified, false, "Expected the ensVerified to be set")
compare(contactDetails.localNickname, "", "Expected the local nickname to be empty") compare(contactDetails.localNickname, "", "Expected the local nickname to be empty")
compare(contactDetails.alias, contactDetails.profileStore.username, "Expected the alias to be set") compare(contactDetails.alias, contactDetails.profileStore.username, "Expected the alias to be set")
compare(contactDetails.icon, contactDetails.profileStore.icon, "Expected the icon to be set") compare(contactDetails.icon, contactDetails.profileStore.icon, "Expected the icon to be set")

2
ui/app/AppLayouts/Profile/helpers/ContactDetails.qml
View File

@ -78,7 +78,7 @@ QObject {
readonly property var ownProfile: QObject { readonly property var ownProfile: QObject {
readonly property string displayName: root.profileStore.displayName readonly property string displayName: root.profileStore.displayName
readonly property string ensName: root.profileStore.name readonly property string ensName: root.profileStore.name
readonly property bool isEnsVerified: root.profileStore.name !== "" readonly property bool isEnsVerified: root.profileStore.name !== "" && Utils.isValidEns(root.profileStore.name)
readonly property string localNickname: "" readonly property string localNickname: ""
readonly property string alias: root.profileStore.username readonly property string alias: root.profileStore.username
readonly property string icon: root.profileStore.icon readonly property string icon: root.profileStore.icon