From 338f1f6f473c5a935953efd10cda56d84b8feddd Mon Sep 17 00:00:00 2001
From: Dario Gabriel Lipicar <dario@status.im>
Date: Mon, 18 Nov 2024 10:00:23 -0300
Subject: [PATCH] chore: fixed pr comments

---
 ui/app/AppLayouts/Wallet/views/RightTabView.qml   | 15 +++++++++++----
 .../shared/views/TransactionContextMenu.qml       |  2 +-
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/ui/app/AppLayouts/Wallet/views/RightTabView.qml b/ui/app/AppLayouts/Wallet/views/RightTabView.qml
index 75ea99bb86..2109440cb3 100644
--- a/ui/app/AppLayouts/Wallet/views/RightTabView.qml
+++ b/ui/app/AppLayouts/Wallet/views/RightTabView.qml
@@ -24,6 +24,12 @@ import "../views/collectibles"
 RightTabBaseView {
     id: root
 
+    enum TabIndex {
+        Assets = 0,
+        Collectibles = 1,
+        Activity = 2
+    }
+
     property SharedStores.RootStore sharedRootStore
 
     property alias currentTabIndex: walletTabBar.currentIndex
@@ -149,18 +155,19 @@ RightTabBaseView {
                     icon.color: checked ? Theme.palette.primaryColor1 : Theme.palette.baseColor1
                     Behavior on icon.color { ColorAnimation { duration: 200; easing.type: Easing.InOutQuad } }
                     highlighted: checked
-                    visible: walletTabBar.currentIndex !== 2 // TODO #16761: Re-enable filter for activity when implemented
+                    visible: walletTabBar.currentIndex !== RightTabView.TabIndex.Activity // TODO #16761: Re-enable filter for activity when implemented
                 }
             }
+
             Loader {
                 id: mainViewLoader
                 Layout.fillWidth: true
                 Layout.fillHeight: true
                 sourceComponent: {
                     switch (walletTabBar.currentIndex) {
-                    case 0: return assetsView
-                    case 1: return collectiblesView
-                    case 2: return historyView
+                        case RightTabView.TabIndex.Assets: return assetsView
+                        case RightTabView.TabIndex.Collectibles: return collectiblesView
+                        case RightTabView.TabIndex.Activity: return historyView
                     }
                 }
 
diff --git a/ui/imports/shared/views/TransactionContextMenu.qml b/ui/imports/shared/views/TransactionContextMenu.qml
index c4245033e3..7fd09fa72a 100644
--- a/ui/imports/shared/views/TransactionContextMenu.qml
+++ b/ui/imports/shared/views/TransactionContextMenu.qml
@@ -12,7 +12,7 @@ StatusMenu {
 
     StatusAction {
         objectName: "viewTxOnExplorerItem"
-        text: qsTr("View on ") + networkExplorerName
+        text: qsTr("View on %1").arg(networkExplorerName)
         icon.name: "link"
         onTriggered: root.viewTxOnExplorerRequested()
     }