fix(@desktop/syncing): keypair syncing - function renamed to avoid confusion, request from the code review

This commit is contained in:
Sale Djenic 2023-06-29 08:26:03 +02:00 committed by saledjenic
parent 241956d537
commit 319bf7a69e
5 changed files with 8 additions and 8 deletions

View File

@ -50,7 +50,7 @@ method advertise*(self: AccessInterface) {.base.} =
method enableDevice*(self: AccessInterface, installationId: string, enable: bool) {.base.} = method enableDevice*(self: AccessInterface, installationId: string, enable: bool) {.base.} =
raise newException(ValueError, "No implementation available") raise newException(ValueError, "No implementation available")
method authenticateLoggedInUser*(self: AccessInterface) {.base.} = method generateConnectionStringAndRunSetupSyncingPopup*(self: AccessInterface) {.base.} =
raise newException(ValueError, "No implementation available") raise newException(ValueError, "No implementation available")
method onLoggedInUserAuthenticated*(self: AccessInterface, pin: string, password: string, keyUid: string, additinalPathsDetails: Table[string, KeyDetails]) {.base.} = method onLoggedInUserAuthenticated*(self: AccessInterface, pin: string, password: string, keyUid: string, additinalPathsDetails: Table[string, KeyDetails]) {.base.} =

View File

@ -100,7 +100,7 @@ method updateOrAddDevice*(self: Module, installation: InstallationDto) =
method updateInstallationName*(self: Module, installationId: string, name: string) = method updateInstallationName*(self: Module, installationId: string, name: string) =
self.view.model().updateItemName(installationId, name) self.view.model().updateItemName(installationId, name)
method authenticateLoggedInUser*(self: Module) = method generateConnectionStringAndRunSetupSyncingPopup*(self: Module) =
var additionalBip44Paths: seq[string] var additionalBip44Paths: seq[string]
if singletonInstance.userProfile.getIsKeycardUser(): if singletonInstance.userProfile.getIsKeycardUser():
additionalBip44Paths.add(account_constants.PATH_WHISPER) additionalBip44Paths.add(account_constants.PATH_WHISPER)

View File

@ -133,8 +133,8 @@ QtObject:
proc openPopupWithConnectionString*(self: View, rawConnectionString: string) = proc openPopupWithConnectionString*(self: View, rawConnectionString: string) =
self.openPopupWithConnectionStringSignal(rawConnectionString) self.openPopupWithConnectionStringSignal(rawConnectionString)
proc authenticateLoggedInUser*(self: View) {.slot.} = proc generateConnectionStringAndRunSetupSyncingPopup*(self: View) {.slot.} =
self.delegate.authenticateLoggedInUser() self.delegate.generateConnectionStringAndRunSetupSyncingPopup()
proc validateConnectionString*(self: View, connectionString: string): string {.slot.} = proc validateConnectionString*(self: View, connectionString: string): string {.slot.} =
return self.delegate.validateConnectionString(connectionString) return self.delegate.validateConnectionString(connectionString)

View File

@ -37,8 +37,8 @@ QtObject {
root.devicesModule.enableDevice(installationId, enable) root.devicesModule.enableDevice(installationId, enable)
} }
function authenticateLoggedInUser() { function generateConnectionStringAndRunSetupSyncingPopup() {
root.devicesModule.authenticateLoggedInUser() root.devicesModule.generateConnectionStringAndRunSetupSyncingPopup()
} }
function validateConnectionString(connectionString) { function validateConnectionString(connectionString) {

View File

@ -54,7 +54,7 @@ SettingsContentBase {
} }
function setupSyncing() { function setupSyncing() {
root.devicesStore.authenticateLoggedInUser() root.devicesStore.generateConnectionStringAndRunSetupSyncingPopup()
} }
} }
@ -133,7 +133,7 @@ SettingsContentBase {
if (deviceEnabled) if (deviceEnabled)
d.personalizeDevice(model) d.personalizeDevice(model)
else else
d.setupSyncing(SetupSyncingPopup.GenerateSyncCode) d.setupSyncing()
} }
} }
} }