From 271ccbb82059eae003b162fa6e028d7af9cda560 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Luk=C3=A1=C5=A1=20Tinkl?= Date: Fri, 2 Dec 2022 13:39:01 +0100 Subject: [PATCH] fix(settings): open links in external browser remove the dialog that asks users if they would like to open a link in Status Desktop's browser and always open them in the user's external browser Fixes #8568 --- src/app/global/local_account_sensitive_settings.nim | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/app/global/local_account_sensitive_settings.nim b/src/app/global/local_account_sensitive_settings.nim index c22b1bb9dc..eb257d3ffd 100644 --- a/src/app/global/local_account_sensitive_settings.nim +++ b/src/app/global/local_account_sensitive_settings.nim @@ -501,7 +501,8 @@ QtObject: proc showBrowserSelectorChanged*(self: LocalAccountSensitiveSettings) {.signal.} proc getShowBrowserSelector*(self: LocalAccountSensitiveSettings): bool {.slot.} = - getSettingsProp[bool](self, LSS_KEY_SHOW_BROWSER_SELECTOR, newQVariant(DEFAULT_SHOW_BROWSER_SELECTOR)) + # getSettingsProp[bool](self, LSS_KEY_SHOW_BROWSER_SELECTOR, newQVariant(DEFAULT_SHOW_BROWSER_SELECTOR)) # https://github.com/status-im/status-desktop/issues/8568 + return false proc setShowBrowserSelector*(self: LocalAccountSensitiveSettings, value: bool) {.slot.} = setSettingsProp(self, LSS_KEY_SHOW_BROWSER_SELECTOR, newQVariant(value)): self.showBrowserSelectorChanged() @@ -514,7 +515,8 @@ QtObject: proc openLinksInStatusChanged*(self: LocalAccountSensitiveSettings) {.signal.} proc getOpenLinksInStatus*(self: LocalAccountSensitiveSettings): bool {.slot.} = - getSettingsProp[bool](self, LSS_KEY_OPEN_LINKS_IN_STATUS, newQVariant(DEFAULT_OPEN_LINKS_IN_STATUS)) + # getSettingsProp[bool](self, LSS_KEY_OPEN_LINKS_IN_STATUS, newQVariant(DEFAULT_OPEN_LINKS_IN_STATUS)) # https://github.com/status-im/status-desktop/issues/8568 + return false proc setOpenLinksInStatus*(self: LocalAccountSensitiveSettings, value: bool) {.slot.} = setSettingsProp(self, LSS_KEY_OPEN_LINKS_IN_STATUS, newQVariant(value)): self.openLinksInStatusChanged()