From 24cdab41c698e855bcbab0d961851af2ac06890b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Soko=C5=82owski?= Date: Wed, 5 Jul 2023 19:59:57 +0200 Subject: [PATCH] ci: fix read-only FS errors in AppImage MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit After a LOT of work from @jrainville bisecting the release branch he identified the issue to be this commit: https://github.com/status-im/status-desktop/commit/dad8e453 ci: bump client build retries to 20 Which actually was poorly squashed by @iurimatias and contains the commit that also adds the retries in the first place: https://github.com/status-im/status-desktop/commit/a5ba2537 ci: retry nim_status_client build 3 times The reason why that's an issue is because normally it was caled by `make tgz-linux` target which included this setting: ``` override RESOURCES_LAYOUT := $(PRODUCTION_PARAMETERS) ``` Which caused `NIM_PARAMS` to use `-d:development` instead of `-d:production`. The result was the app trying to write config file changes to the read-only filesystem of the AppImage. Resolves: https://github.com/status-im/status-desktop/issues/11295 Signed-off-by: Jakub SokoĊ‚owski --- Makefile | 2 +- ci/Jenkinsfile.linux | 5 +++++ ci/Jenkinsfile.tests-e2e | 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 6f1b703a38..0b8aeb2a6e 100644 --- a/Makefile +++ b/Makefile @@ -444,7 +444,7 @@ endif NIM_PARAMS += -d:chronicles_sinks=textlines[stdout],textlines[nocolors,dynamic],textlines[file,nocolors] -d:chronicles_runtime_filtering=on -d:chronicles_default_output_device=dynamic -RESOURCES_LAYOUT := -d:development +RESOURCES_LAYOUT ?= -d:development # When modifying files that are not tracked in NIM_SOURCES (see below), # e.g. vendor/*.nim, REBUILD_NIM=true can be supplied to `make` to ensure a diff --git a/ci/Jenkinsfile.linux b/ci/Jenkinsfile.linux index 1a5c7a60ac..3880507a7b 100644 --- a/ci/Jenkinsfile.linux +++ b/ci/Jenkinsfile.linux @@ -79,6 +79,11 @@ pipeline { } stage('Client') { + environment { + /* Hack-fix for wrong config path location causing: + * Error: unhandled exception: Read-only file system */ + RESOURCES_LAYOUT = '-d:production' + } steps { script { /* Temporary hack-fix for failing Linux builds: * https://github.com/status-im/infra-ci/issues/88 */ diff --git a/ci/Jenkinsfile.tests-e2e b/ci/Jenkinsfile.tests-e2e index cac45cab52..43427fbfab 100644 --- a/ci/Jenkinsfile.tests-e2e +++ b/ci/Jenkinsfile.tests-e2e @@ -96,6 +96,9 @@ pipeline { stage('Client') { environment { GANACHE_NETWORK_RPC_URL = "http://localhost:${env.GANACHE_RPC_PORT}" + /* Hack-fix for wrong config path location causing: + * Error: unhandled exception: Read-only file system */ + RESOURCES_LAYOUT = '-d:production' } steps { script { /* Temporary hack-fix for failing Linux builds: