status-im
/
status-desktop
mirror of https://github.com/status-im/status-desktop.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(Communities): move backup community popup logic to onClosed handler 

The transfer ownership popup triggered by the backup community baner button
was behaving weirdly because the banner from where it originates lives inside
a loader that is deactivated once the popup was opened.

Moving the logic that deactivates the loader into the onClosed handler of the
popup solves this issue.

Thanks to @pinebit for getting to the bottom of this!

Fixes #2997
This commit is contained in:
Pascal Precht 2021-08-12 13:14:12 +02:00 committed by Iuri Matias
parent d3fdd4a575
commit 1ec6583494
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ui/app/AppLayouts/Chat/CommunityComponents/BackUpCommuntyBanner.qml
View File

@ -62,9 +62,6 @@ Rectangle {
anchors.top: backUpText.bottom
anchors.topMargin: Style.current.padding
onClicked: {
let hiddenBannerIds = appSettings.hiddenCommunityBackUpBanners
hiddenBannerIds.push(chatsModel.communities.activeCommunity.id)
appSettings.hiddenCommunityBackUpBanners = hiddenBannerIds
openPopup(transferOwnershipPopup, {privateKey: chatsModel.communities.exportCommunity()})
}
}
@ -74,6 +71,9 @@ Rectangle {
TransferOwnershipPopup {
anchors.centerIn: parent
onClosed: {
let hiddenBannerIds = appSettings.hiddenCommunityBackUpBanners
hiddenBannerIds.push(chatsModel.communities.activeCommunity.id)
appSettings.hiddenCommunityBackUpBanners = hiddenBannerIds
destroy()
}
}