chore: disable history archive for new user and add advanced setting

Fixes #14534

src/app/modules/main/profile_section/advanced/controller.nim

@@ -142,3 +142,12 @@ proc toggleCommunitySection*(self: Controller) =
 
 proc toggleNodeManagementSection*(self: Controller) =
   self.events.emit(TOGGLE_SECTION, ToggleSectionArgs(sectionType: SectionType.NodeManagement))
+
+proc isCommunityHistoryArchiveSupportEnabled*(self: Controller): bool =
+  self.nodeConfigurationService.isCommunityHistoryArchiveSupportEnabled()
+
+proc enableCommunityHistoryArchiveSupport*(self: Controller): bool =
+  self.nodeConfigurationService.enableCommunityHistoryArchiveSupport()
+
+proc disableCommunityHistoryArchiveSupport*(self: Controller): bool =
+  self.nodeConfigurationService.disableCommunityHistoryArchiveSupport()

src/app/modules/main/profile_section/advanced/io_interface.nim

@@ -69,6 +69,15 @@ method isDebugEnabled*(self: AccessInterface): bool {.base.} =
 method isRuntimeLogLevelSet*(self: AccessInterface): bool {.base.} =
   raise newException(ValueError, "No implementation available")
 
+method isCommunityHistoryArchiveSupportEnabled*(self: AccessInterface): bool {.base.} =
+  raise newException(ValueError, "No implementation available")
+
+method enableCommunityHistoryArchiveSupport*(self: AccessInterface) {.base.} =
+  raise newException(ValueError, "No implementation available")
+
+method disableCommunityHistoryArchiveSupport*(self: AccessInterface) {.base.} =
+  raise newException(ValueError, "No implementation available")
+
 method toggleDebug*(self: AccessInterface) {.base.} =
   raise newException(ValueError, "No implementation available")
 

src/app/modules/main/profile_section/advanced/module.nim

@@ -117,6 +117,17 @@ method onNimbusProxyToggled*(self: Module) =
 method isRuntimeLogLevelSet*(self: Module): bool =
   return constants.runtimeLogLevelSet()
 
+method isCommunityHistoryArchiveSupportEnabled*(self: Module): bool =
+  return self.controller.isCommunityHistoryArchiveSupportEnabled()
+
+method enableCommunityHistoryArchiveSupport*(self: Module) =
+  if self.controller.enableCommunityHistoryArchiveSupport():
+    self.view.archiveProtocolEnabledChanged()
+
+method disableCommunityHistoryArchiveSupport*(self: Module) =
+  if self.controller.disableCommunityHistoryArchiveSupport():
+    self.view.archiveProtocolEnabledChanged()
+
 method toggleWalletSection*(self: Module) =
   self.controller.toggleWalletSection()
 

src/app/modules/main/profile_section/advanced/view.nim

@@ -103,6 +103,19 @@ QtObject:
   QtProperty[bool] isRuntimeLogLevelSet:
     read = getIsRuntimeLogLevelSet
 
+  proc archiveProtocolEnabledChanged*(self: View) {.signal.}
+  proc getArchiveProtocolEnabled*(self: View): bool {.slot.} =
+    return self.delegate.isCommunityHistoryArchiveSupportEnabled()
+  QtProperty[bool] archiveProtocolEnabled:
+    read = getArchiveProtocolEnabled
+    notify = archiveProtocolEnabledChanged
+
+  proc enableCommunityHistoryArchiveSupport*(self: View) {.slot.} =
+    self.delegate.enableCommunityHistoryArchiveSupport()
+
+  proc disableCommunityHistoryArchiveSupport*(self: View) {.slot.} =
+    self.delegate.disableCommunityHistoryArchiveSupport()
+
   proc toggleWalletSection*(self: View) {.slot.} =
     self.delegate.toggleWalletSection()
 

src/app_service/common/network_constants.nim

@@ -264,7 +264,7 @@ var NODE_CONFIG* = %* {
   },
   "Networks": NETWORKS,
   "TorrentConfig": {
-    "Enabled": true,
+    "Enabled": false,
     "Port": TORRENT_CONFIG_PORT,
     "DataDir": DEFAULT_TORRENT_CONFIG_DATADIR,
     "TorrentDir": DEFAULT_TORRENT_CONFIG_TORRENTDIR

src/app_service/service/node_configuration/service.nim

@@ -56,14 +56,6 @@ proc adaptNodeSettingsForTheAppNeed(self: Service) =
   self.configuration.LogFile = "./geth.log"
   self.configuration.ShhextConfig.BackupDisabledDataDir = "./"
 
-  if (not self.isCommunityHistoryArchiveSupportEnabled()):
-    # Force community archive support true on Desktop
-    # TODO those lines can be removed in the future once we are sure no one has used a legacy client where it is off
-    if (self.enableCommunityHistoryArchiveSupport()):
-      self.configuration.TorrentConfig.Enabled = true
-    else:
-      error "Setting Community History Archive On failed"
-
 proc init*(self: Service) =
   try:
     let response = status_node_config.getNodeConfig()
@@ -123,6 +115,16 @@ proc enableCommunityHistoryArchiveSupport*(self: Service): bool =
     error "error enabling community history archive support: ", errDescription = response.error.message
     return false
 
+  self.configuration.TorrentConfig.Enabled = true
+  return true
+
+proc disableCommunityHistoryArchiveSupport*(self: Service): bool =
+  let response = status_node_config.disableCommunityHistoryArchiveSupport()
+  if(not response.error.isNil):
+    error "error disabling community history archive support: ", errDescription = response.error.message
+    return false
+
+  self.configuration.TorrentConfig.Enabled = false
   return true
 
 proc getFleet*(self: Service): Fleet =

src/backend/node_config.nim

@@ -33,4 +33,11 @@ proc enableCommunityHistoryArchiveSupport*(): RpcResponse[JsonNode] =
     result = core.callPrivateRPC("enableCommunityHistoryArchiveProtocol".prefix)
   except RpcException as e:
     error "error doing rpc request", methodName = "enableCommunityHistoryArchiveProtocol", exception=e.msg
+    raise newException(RpcException, e.msg)
+
+proc disableCommunityHistoryArchiveSupport*(): RpcResponse[JsonNode] =
+  try:
+    result = core.callPrivateRPC("disableCommunityHistoryArchiveProtocol".prefix)
+  except RpcException as e:
+    error "error doing rpc request", methodName = "disableCommunityHistoryArchiveProtocol", exception=e.msg
     raise newException(RpcException, e.msg)

ui/app/AppLayouts/Communities/controls/Options.qml

@@ -31,11 +31,20 @@ ColumnLayout {
         StatusCheckBox {
             id: archiveSupportToggle
             width: (parent.width-12)
-            checked: true
+            checked: false
             leftSide: false
             padding: 0
             anchors.verticalCenter: parent.verticalCenter
             text: qsTr("Community history service")
+
+            StatusToolTip {
+                text: qsTr('For this Community Setting to work, you also need to activate "Archive Protocol Enabled" in Advanced Settings')
+                visible: hoverHandler.hovered
+            }
+            HoverHandler {
+                id: hoverHandler
+                enabled: true
+            }
         }
     }
 

ui/app/AppLayouts/Profile/ProfileLayout.qml

@@ -207,7 +207,6 @@ StatusSectionLayout {
             sourceComponent: MessagingView {
                 implicitWidth: parent.width
                 implicitHeight: parent.height
-                advancedStore: root.store.advancedStore
                 messagingStore: root.store.messagingStore
                 sectionTitle: root.store.getNameForSubsection(Constants.settingsSubsection.messaging)
                 contactsStore: root.store.contactsStore

ui/app/AppLayouts/Profile/stores/AdvancedStore.qml

@@ -18,6 +18,7 @@ QtObject {
     readonly property bool isWakuV2ShardedCommunitiesEnabled: localAppSettings.wakuV2ShardedCommunitiesEnabled ?? false
     property int logMaxBackups: advancedModule ? advancedModule.logMaxBackups : 1
     property bool isRuntimeLogLevelSet: advancedModule ? advancedModule.isRuntimeLogLevelSet: false
+    readonly property bool archiveProtocolEnabled: advancedModule ? advancedModule.archiveProtocolEnabled : false
 
     property var customNetworksModel: advancedModule? advancedModule.customNetworksModel : []
 
@@ -150,6 +151,17 @@ QtObject {
         localAppSettings.createCommunityEnabled = !localAppSettings.createCommunityEnabled
     }
 
+    function toggleArchiveProtocolEnabled() {
+        if(!advancedModule)
+            return
+
+        if (root.archiveProtocolEnabled) {
+            advancedModule.disableCommunityHistoryArchiveSupport()
+        } else {
+            advancedModule.enableCommunityHistoryArchiveSupport()
+        }
+    }
+
     function toggleManageCommunityOnTestnet() {
         root.isManageCommunityOnTestModeEnabled = !root.isManageCommunityOnTestModeEnabled
     }

ui/app/AppLayouts/Profile/views/AdvancedView.qml

@@ -193,6 +193,17 @@ SettingsContentBase {
                 }
             }
 
+            StatusSettingsLineButton {
+                anchors.leftMargin: 0
+                anchors.rightMargin: 0
+                text: qsTr("Archive Protocol Enabled")
+                isSwitch: true
+                switchChecked: root.advancedStore.archiveProtocolEnabled
+                onClicked: {
+                    root.advancedStore.toggleArchiveProtocolEnabled()
+                }
+            }
+
             Separator {
                 width: parent.width
             }

ui/app/AppLayouts/Profile/views/MessagingView.qml

@@ -25,7 +25,6 @@ SettingsContentBase {
     id: root
 
     property MessagingStore messagingStore
-    property AdvancedStore advancedStore
     property ContactsStore contactsStore
 
     ColumnLayout {