From 19f6cf9e11ccf6a11ca8e8229a461a890d4bb962 Mon Sep 17 00:00:00 2001 From: Anastasiya Semenkevich Date: Tue, 11 Jun 2024 17:02:30 +0300 Subject: [PATCH] chore: removed unnecessary steps, brought back commented ones --- .../test_onboarding_generate_new_keys.py | 3 --- .../onboarding/test_onboarding_import_seed.py | 18 ++++++++---------- .../test_settings_password_change_password.py | 3 --- 3 files changed, 8 insertions(+), 16 deletions(-) diff --git a/test/e2e/tests/onboarding/test_onboarding_generate_new_keys.py b/test/e2e/tests/onboarding/test_onboarding_generate_new_keys.py index 325a9f89bb..1de4834347 100755 --- a/test/e2e/tests/onboarding/test_onboarding_generate_new_keys.py +++ b/test/e2e/tests/onboarding/test_onboarding_generate_new_keys.py @@ -133,6 +133,3 @@ def test_generate_new_keys_sign_out_from_settings(aut, main_window, keys_screen, with step('Click sign out and quit in settings'): sign_out_screen = settings.left_panel.open_sign_out_and_quit() sign_out_screen.sign_out_and_quit() - - with step('Check the application process is not running'): - psutil.Process(aut.pid).wait(timeout=30) diff --git a/test/e2e/tests/onboarding/test_onboarding_import_seed.py b/test/e2e/tests/onboarding/test_onboarding_import_seed.py index e976283939..5e429cdb51 100644 --- a/test/e2e/tests/onboarding/test_onboarding_import_seed.py +++ b/test/e2e/tests/onboarding/test_onboarding_import_seed.py @@ -69,14 +69,12 @@ def test_import_seed_phrase(keys_screen, main_window, aut: AUT, user_account, de profile_popup = user_canvas.open_profile_popup_from_online_identifier() assert profile_popup.user_name == user_account.name - # TODO: https://github.com/status-im/status-desktop/issues/15124 - # TODO: https://github.com/status-im/status-desktop/issues/15131 - # with step('Restart application and try re-importing seed phrase again'): - # aut.restart() - # enter_seed_view = LoginView().add_existing_status_user().open_keys_view().open_enter_seed_phrase_view() - # enter_seed_view.input_seed_phrase(user_account.seed_phrase, autocomplete) - # confirm_import = enter_seed_view.click_import_seed_phrase_button() + with step('Restart application and try re-importing seed phrase again'): + aut.restart() + enter_seed_view = LoginView().add_existing_status_user().open_keys_view().open_enter_seed_phrase_view() + enter_seed_view.input_seed_phrase(user_account.seed_phrase, autocomplete) + confirm_import = enter_seed_view.click_import_seed_phrase_button() - #with step('Verify that keys already exist popup appears and text is correct'): - # assert confirm_import.get_key_exist_title() == KeysExistText.KEYS_EXIST_TITLE.value - # assert KeysExistText.KEYS_EXIST_TEXT.value in confirm_import.get_text_labels() + with step('Verify that keys already exist popup appears and text is correct'): + assert confirm_import.get_key_exist_title() == KeysExistText.KEYS_EXIST_TITLE.value + assert KeysExistText.KEYS_EXIST_TEXT.value in confirm_import.get_text_labels() diff --git a/test/e2e/tests/settings/settings_password/test_settings_password_change_password.py b/test/e2e/tests/settings/settings_password/test_settings_password_change_password.py index bcd9134617..1068873b84 100644 --- a/test/e2e/tests/settings/settings_password/test_settings_password_change_password.py +++ b/test/e2e/tests/settings/settings_password/test_settings_password_change_password.py @@ -35,9 +35,6 @@ def test_change_password_and_login(aut: AUT, main_screen: MainWindow, user_accou with step('Click re-encrypt data button and then restart'): ChangePasswordPopup().click_re_encrypt_data_restart_button() - with step('Verify the application process is not running'): - psutil.Process(aut.pid).wait(timeout=30) - with step('Restart application'): aut.restart()