remove vendor/nim-nat-traversal

and fix/hide some warnings

.gitmodules

@@ -4,9 +4,6 @@
 [submodule "vendor/nimbus-build-system"]
 	path = vendor/nimbus-build-system
 	url = https://github.com/status-im/nimbus-build-system.git
-[submodule "vendor/nim-nat-traversal"]
-	path = vendor/nim-nat-traversal
-	url = https://github.com/status-im/nim-nat-traversal.git
 [submodule "vendor/nim-stew"]
 	path = vendor/nim-stew
 	url = https://github.com/status-im/nim-stew.git

config.nims

@@ -33,3 +33,11 @@ else:
   switch("passL", "-Wl,-as-needed")
 
 --define:chronicles_line_numbers # useful when debugging
+
+# The compiler doth protest too much, methinks, about all these cases where it can't
+# do its (N)RVO pass: https://github.com/nim-lang/RFCs/issues/230
+switch("warning", "ObservableStores:off")
+
+# Too many false positives for "Warning: method has lock level <unknown>, but another method has 0 [LockLevel]"
+switch("warning", "LockLevel:off")
+

src/app/chat/views/chat_members.nim

@@ -1,8 +1,5 @@
-import NimQml, Tables
+import NimQml, Tables,
-import ../../../status/chat/[chat, message]
+  ../../../status/[chat/chat, status, ens]
-import ../../../status/chat as status_chat
-import ../../../status/status
-import ../../../status/ens
 
 type
   ChatMemberRoles {.pure.} = enum
@@ -20,7 +17,7 @@ QtObject:
 
   proc setup(self: ChatMembersView) = self.QAbstractListModel.setup
 
-  proc delete(self: ChatMembersView) = 
+  proc delete(self: ChatMembersView) =
     self.members = @[]
     self.QAbstractListModel.delete
 

src/app/profile/views/contact_list.nim

@@ -1,6 +1,5 @@
 import NimQml
 import Tables
-import strformat
 import ../../../status/profile/profile
 from ../../../status/ens import nil
 
@@ -18,14 +17,14 @@ QtObject:
 
   proc setup(self: ContactList) = self.QAbstractListModel.setup
 
-  proc delete(self: ContactList) = 
+  proc delete(self: ContactList) =
     self.contacts = @[]
     self.QAbstractListModel.delete
 
   proc newContactList*(): ContactList =
     new(result, delete)
     # TODO: (rramos) contacts should be a table[string, Profile] instead, with the key being the public key
-    # This is to optimize determining if a contact is part of the contact list or not 
+    # This is to optimize determining if a contact is part of the contact list or not
     # (including those that do not have a system tag)
     result.contacts = @[]
     result.setup

src/app/profile/views/mailservers_list.nim

@@ -1,6 +1,6 @@
 import NimQml
 import Tables
-import ../../../status/profile/[profile, mailserver]
+import ../../../status/profile/mailserver
 
 type
   MailServerRoles {.pure.} = enum
@@ -13,7 +13,7 @@ QtObject:
 
   proc setup(self: MailServersList) = self.QAbstractListModel.setup
 
-  proc delete(self: MailServersList) = 
+  proc delete(self: MailServersList) =
     self.mailservers = @[]
     self.QAbstractListModel.delete
 

src/status/libstatus/contracts.nim

@@ -1,5 +1,4 @@
-import sequtils, strformat, sugar, chronicles, typeinfo, macros, tables
+import sequtils, strformat, sugar, macros, tables
-import ./utils as status_utils
 import eth/common/eth_types, stew/byteutils, nimcrypto
 from eth/common/utils import parseAddress
 
@@ -12,7 +11,7 @@ type Method = object
   name: string
   signature: string
   noPadding: bool
-    
+
 type Contract* = ref object
   name*: string
   network*: Network

src/status/libstatus/types.nim

@@ -74,7 +74,7 @@ type AccountArgs* = ref object of Args
     account*: Account
 
 type
-  StatusGoException* = object of Exception
+  StatusGoException* = object of CatchableError
 
 type
   Transaction* = ref object

vendor/nim-nat-traversal

@@ -1 +0,0 @@
-Subproject commit 2403c33929c74f2d150f50dc8bc3a598af70661a

vendor/nimbus-build-system

@@ -1 +1 @@
-Subproject commit ae49e03af6f36393eb7e0fc02c1c47df42efd2de
+Subproject commit 767c8e0fb433da5276c4ac3e61b3360e003536a7