status-im
/
status-desktop
mirror of https://github.com/status-im/status-desktop.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix(Language): App crashes when language is changed 

Enabled restart info popup after language is changed --> Workaround to temporary resolve the crash we have when language is changed (`startupModule` is null and some qml bindings are still calling this dead pointer) so, change language will not retranslate and instead, also on mac and win, the app will need a restart to apply the new language.

Disabled retranslations for all os on the corresponding service.

Will temporary fix #7709
This commit is contained in:
Noelia 2022-10-07 15:54:08 +02:00 committed by Noelia
parent 238e7fa104
commit 11fcd82b82
2 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/app_service/service/language/service.nim
View File

@ -26,7 +26,7 @@ proc delete*(self: Service) =
proc newService*(events: EventEmitter): Service =
result = Service()
result.events = events
result.shouldRetranslate = not defined(linux)
result.shouldRetranslate = false #not defined(linux)
proc obtainLanguages(dir: string): seq[string] =
let localeRe = re".*qml_(.*).qm"

13
ui/app/AppLayouts/Profile/views/LanguageView.qml
View File

@ -168,16 +168,19 @@ SettingsContentBase {
onItemPickerChanged: {
if(selected && root.languageStore.currentLanguage !== key) {
// IMPORTANT: Workaround to temporary resolve the crash we have when language is changed (`startupModule` is null and some qml bindings are still calling this dead pointer) so, change language will not retranslate
// and instead, also on mac and win, the app will quit to apply the new language
// TEMPORARY: It should be removed as it is only used in Linux OS but it must be investigated how to change language in execution time, as well, in Linux (will be addressed in another task)
if (Qt.platform.os === Constants.linux) {
//if (Qt.platform.os === Constants.linux) {
root.changeLanguage(key)
linuxConfirmationDialog.active = true
linuxConfirmationDialog.item.newLocale = key
linuxConfirmationDialog.item.open()
}
else {
root.changeLanguage(key)
}
// }
//else {
// root.changeLanguage(key)
//}
}
}
}