From 0d67d5138bc30c203157000a9d702f276368b913 Mon Sep 17 00:00:00 2001 From: Alex Jbanca Date: Wed, 23 Oct 2024 14:32:16 +0300 Subject: [PATCH] fix(connectionStatus): Remove redundant `changed` notifier from nim There is no need to emit `changed` event for the QObject exposed from nim if only the underlying data changes. --- src/app/modules/main/network_connection/view.nim | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/app/modules/main/network_connection/view.nim b/src/app/modules/main/network_connection/view.nim index 4c8afa79df..91c757471b 100644 --- a/src/app/modules/main/network_connection/view.nim +++ b/src/app/modules/main/network_connection/view.nim @@ -68,12 +68,9 @@ QtObject: case website: of BLOCKCHAINS: self.blockchainNetworkConnection.updateValues(completelyDown, connectionState, chainIds, lastCheckedAt) - self.blockchainNetworkConnectionChanged() of COLLECTIBLES: self.collectiblesNetworkConnection.updateValues(completelyDown, connectionState, chainIds, lastCheckedAt) - self.collectiblesNetworkConnectionChanged() of MARKET: self.marketValuesNetworkConnection.updateValues(completelyDown, connectionState, chainIds, lastCheckedAt) - self.marketValuesNetworkConnectionChanged() self.networkConnectionStatusUpdate(website, completelyDown, connectionState, chainIds, float(lastCheckedAt))