status-im
/
status-desktop
mirror of https://github.com/status-im/status-desktop.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

refactor(chat_content): only get Message by ID when needed

This commit is contained in:
Jonathan Rainville 2023-04-20 15:44:45 -04:00
parent 7757c3b47d
commit 0c9b568b95
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/app/modules/main/chat_section/chat_content/module.nim
View File

@ -150,11 +150,8 @@ method currentUserWalletContainsAddress(self: Module, address: string): bool =
return true return true
return false return false
proc buildPinnedMessageItem(self: Module, messageId: string, actionInitiatedBy: string, item: var pinned_msg_item.Item): proc buildPinnedMessageItem(self: Module, message: MessageDto, actionInitiatedBy: string,
bool = item: var pinned_msg_item.Item):bool =
let (message, err) = self.controller.getMessageById(messageId)
if(err.len > 0):
return false
let contactDetails = self.controller.getContactDetails(message.`from`) let contactDetails = self.controller.getContactDetails(message.`from`)
let chatDetails = self.controller.getChatDetails() let chatDetails = self.controller.getChatDetails()
@ -234,7 +231,7 @@ method newPinnedMessagesLoaded*(self: Module, pinnedMessages: seq[PinnedMessageD
var viewItems: seq[pinned_msg_item.Item] var viewItems: seq[pinned_msg_item.Item]
for p in pinnedMessages: for p in pinnedMessages:
var item: pinned_msg_item.Item var item: pinned_msg_item.Item
if(not self.buildPinnedMessageItem(p.message.id, p.pinnedBy, item)): if(not self.buildPinnedMessageItem(p.message, p.pinnedBy, item)):
continue continue
viewItems = item & viewItems # messages are sorted from the most recent to the least recent one viewItems = item & viewItems # messages are sorted from the most recent to the least recent one
@ -251,7 +248,8 @@ method onUnpinMessage*(self: Module, messageId: string) =
method onPinMessage*(self: Module, messageId: string, actionInitiatedBy: string) = method onPinMessage*(self: Module, messageId: string, actionInitiatedBy: string) =
var item: pinned_msg_item.Item var item: pinned_msg_item.Item
if(not self.buildPinnedMessageItem(messageId, actionInitiatedBy, item)): let (message, err) = self.controller.getMessageById(messageId)
if(err.len > 0 or not self.buildPinnedMessageItem(message, actionInitiatedBy, item)):
return return
self.view.pinnedModel().insertItemBasedOnClock(item) self.view.pinnedModel().insertItemBasedOnClock(item)