From 0832cef36b2bbdb2cbc1e70fb374720d6dea6bf5 Mon Sep 17 00:00:00 2001
From: "Michael Bradley, Jr" <michaelsbradleyjr@gmail.com>
Date: Tue, 13 Apr 2021 14:03:19 -0500
Subject: [PATCH] build: fetch macOS Homebrew bottles from GitHub Packages
 instead of bintray

bintray (for open source) is shutting down permanently on May 1:

https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/

At this time downloading from GitHub Packages requires specifying a username
and personal acccess token, but it seems they don't have to be valid. For
example, in the changes to the Makefile I specified `_:_` as the username and
token.

Also, change the minimum macOS version from 10.13 to 10.14 since Homebrew
bottles are no longer built for 10.13 (High Sierra):

https://github.com/Homebrew/discussions/discussions/1264#discussioncomment-601544

Closes #1851
---
 Makefile    | 18 +++++++++---------
 config.nims |  4 ++--
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/Makefile b/Makefile
index 64990e7370..e51ddd771e 100644
--- a/Makefile
+++ b/Makefile
@@ -67,12 +67,12 @@ endif
 
 ifeq ($(detected_OS),Darwin)
  BOTTLES_TARGET := bottles-macos
- CFLAGS := -mmacosx-version-min=10.13
+ CFLAGS := -mmacosx-version-min=10.14
  export CFLAGS
- CGO_CFLAGS := -mmacosx-version-min=10.13
+ CGO_CFLAGS := -mmacosx-version-min=10.14
  export CGO_CFLAGS
  LIBSTATUS_EXT := dylib
- MACOSX_DEPLOYMENT_TARGET := 10.13
+ MACOSX_DEPLOYMENT_TARGET := 10.14
  export MACOSX_DEPLOYMENT_TARGET
  PKG_TARGET := pkg-macos
  RUN_TARGET := run-macos
@@ -118,9 +118,9 @@ $(BOTTLE_OPENSSL):
 	rm -rf bottles/Downloads/openssl* bottles/openssl*
 	mkdir -p bottles/Downloads
 	cd bottles/Downloads && \
-	wget -O openssl.tar.gz "https://bintray.com/homebrew/bottles/download_file?file_path=openssl%401.1-1.1.1g.high_sierra.bottle.tar.gz" && \
-	tar xzf openssl* && \
-	mv openssl@1.1/1.1.1g ../openssl
+	curl -L -o openssl.tar.gz -u _:_ $$(brew info --json=v1 openssl | jq -r '.[0].bottle.stable.files.mojave.url') && \
+	tar xzf openssl.tar.gz && \
+	mv openssl*/* ../openssl
 
 BOTTLE_PCRE := bottles/pcre/INSTALL_RECEIPT.json
 
@@ -128,9 +128,9 @@ $(BOTTLE_PCRE):
 	rm -rf bottles/Downloads/pcre* bottles/pcre*
 	mkdir -p bottles/Downloads
 	cd bottles/Downloads && \
-	wget -O pcre.tar.gz "https://bintray.com/homebrew/bottles/download_file?file_path=pcre-8.44.high_sierra.bottle.tar.gz" && \
-	tar xzf pcre* && \
-	mv pcre/8.44 ../pcre
+	curl -L -o pcre.tar.gz -u _:_ $$(brew info --json=v1 pcre | jq -r '.[0].bottle.stable.files.mojave.url') && \
+	tar xzf pcre.tar.gz && \
+	mv pcre*/* ../pcre
 
 bottles-macos: | $(BOTTLE_OPENSSL) $(BOTTLE_PCRE)
 	rm -rf bottles/Downloads
diff --git a/config.nims b/config.nims
index 7ce0dc4507..6e3de05b7b 100644
--- a/config.nims
+++ b/config.nims
@@ -22,8 +22,8 @@ if defined(macosx):
   switch("passL", "bottles/pcre/lib/libpcre.a")
   # https://code.videolan.org/videolan/VLCKit/-/issues/232
   switch("passL", "-Wl,-no_compact_unwind")
-  # set the minimum supported macOS version to 10.13
-  switch("passC", "-mmacosx-version-min=10.13")
+  # set the minimum supported macOS version to 10.14
+  switch("passC", "-mmacosx-version-min=10.14")
 elif defined(windows):
   --app:gui
   --tlsEmulation:off