status-im/status-desktop
2
0
Fork 0
mirror of https://github.com/status-im/status-desktop.git synced 2025-02-02 17:54:01 +00:00
Code Issues Projects Releases Wiki Activity

fix: avoid duplicating UnfurlURLs requests (#12687)

Browse Source
This commit is contained in:
Igor Sirotin 2023-11-17 15:42:24 +00:00 committed by GitHub
parent ba30afd202
commit 03d4fbcc48
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/app/modules/main/chat_section/chat_content/input_area/controller.nim
View File

@ -219,6 +219,7 @@ proc setText*(self: Controller, text: string, unfurlNewUrls: bool) =
if self.getLinkPreviewEnabled() and len(newUrls) > 0: if self.getLinkPreviewEnabled() and len(newUrls) > 0:
self.messageService.asyncUnfurlUrls(newUrls) self.messageService.asyncUnfurlUrls(newUrls)
self.linkPreviewCache.markAsRequested(newUrls)
proc linkPreviewsFromCache*(self: Controller, urls: seq[string]): Table[string, LinkPreview] = proc linkPreviewsFromCache*(self: Controller, urls: seq[string]): Table[string, LinkPreview] =
return self.linkPreviewCache.linkPreviews(urls) return self.linkPreviewCache.linkPreviews(urls)

14
src/app/modules/main/chat_section/chat_content/input_area/link_preview_cache.nim
View File

@ -1,13 +1,15 @@
import tables import tables, sets
import ../../../../../../app_service/service/message/dto/link_preview import ../../../../../../app_service/service/message/dto/link_preview
type type
LinkPreviewCache* = ref object LinkPreviewCache* = ref object
cache: Table[string, LinkPreview] cache: Table[string, LinkPreview]
requests: HashSet[string]
proc newLinkPreiewCache*(): LinkPreviewCache = proc newLinkPreiewCache*(): LinkPreviewCache =
result = LinkPreviewCache() result = LinkPreviewCache()
result.cache = initTable[string, LinkPreview]() result.cache = initTable[string, LinkPreview]()
result.requests = initHashSet[string]()
# Returns a table of link previews for given `urls`. # Returns a table of link previews for given `urls`.
# If url is not found in cache, it's skipped # If url is not found in cache, it's skipped
@ -31,14 +33,22 @@ proc add*(self: LinkPreviewCache, linkPreviews: Table[string, LinkPreview]): seq
for key, value in pairs(linkPreviews): for key, value in pairs(linkPreviews):
result.add(key) result.add(key)
self.cache[key] = value self.cache[key] = value
self.requests.excl(key)
# Marks the URL as requested.
# This should be used to avoid duplicating unfurl requests.
proc markAsRequested*(self: LinkPreviewCache, urls: seq[string]) =
for url in urls:
self.requests.incl(url)
# Goes though given `urls` and returns a list # Goes though given `urls` and returns a list
# of urls not found in cache. # of urls not found in cache.
proc unknownUrls*(self: LinkPreviewCache, urls: seq[string]): seq[string] = proc unknownUrls*(self: LinkPreviewCache, urls: seq[string]): seq[string] =
for url in urls: for url in urls:
if not self.cache.hasKey(url): if not self.cache.hasKey(url) and not self.requests.contains(url):
result.add(url) result.add(url)
# Clears link preview cache # Clears link preview cache
proc clear*(self: LinkPreviewCache) = proc clear*(self: LinkPreviewCache) =
self.cache.clear() self.cache.clear()
self.requests.clear()