2020-05-14 14:58:08 +00:00
|
|
|
[submodule "vendor/nim-stint"]
|
|
|
|
|
path = vendor/nim-stint
|
2020-05-28 16:45:58 +00:00
|
|
|
url = https://github.com/status-im/nim-stint.git
|
2020-05-14 14:58:08 +00:00
|
|
|
[submodule "vendor/nimbus-build-system"]
|
|
|
|
|
path = vendor/nimbus-build-system
|
2020-05-28 16:45:58 +00:00
|
|
|
url = https://github.com/status-im/nimbus-build-system.git
|
2020-05-14 14:58:08 +00:00
|
|
|
[submodule "vendor/nim-stew"]
|
|
|
|
|
path = vendor/nim-stew
|
2020-05-28 16:45:58 +00:00
|
|
|
url = https://github.com/status-im/nim-stew.git
|
2020-05-14 20:19:01 +00:00
|
|
|
[submodule "vendor/status-go"]
|
|
|
|
|
path = vendor/status-go
|
2020-05-28 16:45:58 +00:00
|
|
|
url = https://github.com/status-im/status-go.git
|
2020-05-16 23:46:46 +00:00
|
|
|
[submodule "vendor/DOtherSide"]
|
|
|
|
|
path = vendor/DOtherSide
|
2020-05-28 16:45:58 +00:00
|
|
|
url = https://github.com/status-im/DOtherSide.git
|
2020-05-16 23:46:46 +00:00
|
|
|
[submodule "vendor/nimqml"]
|
|
|
|
|
path = vendor/nimqml
|
2020-05-28 16:45:58 +00:00
|
|
|
url = https://github.com/status-im/nimqml.git
|
2020-05-21 19:07:55 +00:00
|
|
|
[submodule "vendor/nim-chronicles"]
|
|
|
|
|
path = vendor/nim-chronicles
|
2020-05-28 16:45:58 +00:00
|
|
|
url = https://github.com/status-im/nim-chronicles.git
|
2020-05-21 19:07:55 +00:00
|
|
|
[submodule "vendor/nim-faststreams"]
|
|
|
|
|
path = vendor/nim-faststreams
|
2020-05-28 16:45:58 +00:00
|
|
|
url = https://github.com/status-im/nim-faststreams.git
|
2020-05-21 19:07:55 +00:00
|
|
|
[submodule "vendor/nim-chronos"]
|
|
|
|
|
path = vendor/nim-chronos
|
2020-05-28 16:45:58 +00:00
|
|
|
url = https://github.com/status-im/nim-chronos.git
|
2020-05-21 19:07:55 +00:00
|
|
|
[submodule "vendor/nim-json-serialization"]
|
|
|
|
|
path = vendor/nim-json-serialization
|
2020-05-28 16:45:58 +00:00
|
|
|
url = https://github.com/status-im/nim-json-serialization.git
|
2020-05-21 19:07:55 +00:00
|
|
|
[submodule "vendor/nim-serialization"]
|
|
|
|
|
path = vendor/nim-serialization
|
2020-05-28 16:45:58 +00:00
|
|
|
url = https://github.com/status-im/nim-serialization.git
|
2020-05-19 13:22:38 +00:00
|
|
|
[submodule "vendor/nimcrypto"]
|
|
|
|
|
path = vendor/nimcrypto
|
2020-05-28 16:45:58 +00:00
|
|
|
url = https://github.com/cheatfate/nimcrypto.git
|
2020-05-19 13:22:38 +00:00
|
|
|
[submodule "vendor/uuids"]
|
|
|
|
|
path = vendor/uuids
|
2020-05-28 16:45:58 +00:00
|
|
|
url = https://github.com/pragmagic/uuids.git
|
2020-05-19 13:22:38 +00:00
|
|
|
[submodule "vendor/isaac"]
|
|
|
|
|
path = vendor/isaac
|
2020-05-28 16:45:58 +00:00
|
|
|
url = https://github.com/pragmagic/isaac.git
|
2020-06-10 12:02:21 +00:00
|
|
|
[submodule "vendor/nim-libp2p"]
|
|
|
|
|
path = vendor/nim-libp2p
|
|
|
|
|
url = https://github.com/status-im/nim-libp2p
|
2020-06-17 21:00:47 +00:00
|
|
|
[submodule "vendor/nim-metrics"]
|
|
|
|
|
path = vendor/nim-metrics
|
|
|
|
|
url = https://github.com/status-im/nim-metrics
|
2020-06-23 17:17:58 +00:00
|
|
|
[submodule "vendor/QR-Code-generator"]
|
|
|
|
|
path = vendor/QR-Code-generator
|
|
|
|
|
url = https://github.com/status-im/QR-Code-generator
|
2020-07-14 21:06:02 +00:00
|
|
|
[submodule "vendor/edn.nim"]
|
|
|
|
|
path = vendor/edn.nim
|
|
|
|
|
url = https://github.com/rosado/edn.nim.git
|
2020-09-03 16:06:51 +00:00
|
|
|
[submodule "vendor/nim-secp256k1"]
|
|
|
|
|
path = vendor/nim-secp256k1
|
|
|
|
|
url = https://github.com/status-im/nim-secp256k1
|
|
|
|
|
[submodule "vendor/chroma"]
|
|
|
|
|
path = vendor/chroma
|
|
|
|
|
url = https://github.com/treeform/chroma
|
|
|
|
|
[submodule "vendor/nimPNG"]
|
|
|
|
|
path = vendor/nimPNG
|
|
|
|
|
url = https://github.com/jangko/nimPNG/
|
|
|
|
|
[submodule "vendor/nimage"]
|
|
|
|
|
path = vendor/nimage
|
|
|
|
|
url = https://github.com/Ethosa/nimage/
|
2020-09-25 02:08:03 +00:00
|
|
|
[submodule "vendor/nim-web3"]
|
|
|
|
|
path = vendor/nim-web3
|
|
|
|
|
url = https://github.com/status-im/nim-web3
|
|
|
|
|
[submodule "vendor/nim-json-rpc"]
|
|
|
|
|
path = vendor/nim-json-rpc
|
|
|
|
|
url = https://github.com/status-im/nim-json-rpc
|
|
|
|
|
[submodule "vendor/nim-http-utils"]
|
|
|
|
|
path = vendor/nim-http-utils
|
|
|
|
|
url = https://github.com/status-im/nim-http-utils
|
|
|
|
|
[submodule "vendor/news"]
|
|
|
|
|
path = vendor/news
|
|
|
|
|
url = https://github.com/Tormund/news
|
|
|
|
|
[submodule "vendor/bearssl"]
|
|
|
|
|
path = vendor/bearssl
|
|
|
|
|
url = https://github.com/status-im/nim-bearssl
|
|
|
|
|
[submodule "vendor/nim-eth"]
|
|
|
|
|
path = vendor/nim-eth
|
|
|
|
|
url = https://github.com/status-im/nim-eth
|
2020-09-30 17:46:51 +00:00
|
|
|
[submodule "vendor/nbaser"]
|
|
|
|
|
path = vendor/nbaser
|
|
|
|
|
url = https://github.com/D-Nice/nbaser/
|
|
|
|
|
[submodule "vendor/nim-base32"]
|
|
|
|
|
path = vendor/nim-base32
|
|
|
|
|
url = https://github.com/elktree/nim-base32
|
2021-03-15 18:42:45 +00:00
|
|
|
[submodule "vendor/nim-status-go"]
|
|
|
|
|
path = vendor/nim-status-go
|
|
|
|
|
url = https://github.com/status-im/nim-status-go.git
|
feat: introduce Task Manager threadpool
The `TaskManager` threadpool is a memory-safe replacement for the `spawnAndSend` operations that are currently causing memory issues in status-desktop.
From a fundamental memory management point of view, `libstatus/settings`, `libstatus/contracts`, and `libstatus/tokens` (custom tokens) have all been converted to `{.threadvar.}`s and `Atomic[bool]`s to maintain the cache and `dirty` flag across threads, respectively, eliminating the need for thread locks and incorrect `{.gcsafe.}` compiler overrides.
The successful [recyclable threadpool experiment from `nim-task-runner`](https://github.com/status-im/nim-task-runner/blob/test/use-cases/test/use_cases/test_sync.nim) using `AsyncChannel[ThreadSafeString]`s was brought over to `status-desktop` and implemented in somewhat of a hardcoded manner, as we knew this would save some time instead of trying to create a fully fleshed out `nim-task-runner` API and build a miraculous macro that may or may not be able to generate the needed API.
The threadpool is started by the `TaskManager` and both the `TaskManager` and the `TaskManager`'s threadpool are started as early as possible in the application lifecycle (in `nim_status_client.nim`). The `TaskManager` creates a thread to run the threadpool. During its initialization, the threadpool then spools up all the threads it will manage and puts them in an idle thread sequence. This is to prevent expensive thread creation and teardown happening during the app's lifetime as it is quite expensive and blocks the main thread. When tasks comes in to the pool, the task is sent to an idle thread, or put in a queue if all threads are busy. The idle thread is moved to the busy thread sequence. When a task is completed, the thread is taken out of the busy threads sequence and moved back in to the sequence of idle threads, effectively recycling it.
The first `spawnAndSend` we were able to change over to the new threadpool was `estimate`, which estimates the gas of a sticker purchase transaction.
From the consumer point of view, the existing `spawnAndSend` to achieve this looks like:
```nim
proc estimate*(self: StickersView, packId: int, address: string, price: string, uuid: string) {.slot.} =
let status_stickers = self.status.stickers
spawnAndSend(self, "setGasEstimate") do:
var success: bool
var estimate = status_stickers.estimateGas(packId, address, price, success)
if not success:
estimate = 325000
let result: tuple[estimate: int, uuid: string] = (estimate, uuid)
Json.encode(result)
```
And the new syntax looks like this:
```nim
proc estimate*(self: StickersView, packId: int, address: string, price: string, uuid: string) {.slot.} =
self.status.taskManager.threadPool.stickers.stickerPackPurchaseGasEstimate(cast[pointer](self.vptr), "setGasEstimate", packId, address, price, uuid)
```
The logic inside the `spawnAndSend` body was moved to [src/status/tasks/stickers.nim](https://github.com/status-im/status-desktop/compare/experiment/tasks-3?expand=1#diff-09e57eef00b0cee5c4abdb9039f948d8372e7003e09e934a9b4c7e9167d47658).
This is just the first migration of `spawnAndSend`, however moving the majority of the remaining `spawnAndSend`s will likely just be an exercise in copy/pasta. There will be one or two that may require a bit more thinking, depending how they rely on data from the model.
Once the `spawnAndSend`s have been converted to the threadpool, we can start implementing the [long-running process from the task runner use case experiments](https://github.com/status-im/nim-task-runner/blob/test/use-cases/test/use_cases/test_long_running.nim).
And finally, we can then implement the [async tasks](https://github.com/status-im/nim-task-runner/blob/test/use-cases/test/use_cases/test_async.nim) if needed.
@michaelsbradleyjr and I spent many hours digging in to the depths of nim's memory management in an attempt to understand it. We have created [a presentation with our task runner experiment findings](https://docs.google.com/presentation/d/1ItCxAfsVTcIoH_E4bgvmHljhbU-tC3T6K2A6ahwAedk/edit?usp=sharing), and @michaelsbradleyjr has spent time [answering questions off the back of that presentation.](https://gist.github.com/michaelsbradleyjr/1eaa9937b3fbb4ffff3fb814f0dd82a9).
We have created a fork of `edn.nim` at `status-im/edn.nim` and we need the PR to be merged and the commit hash updated before we can merge this PR in to `status-desktop`.
2021-03-17 06:25:41 +00:00
|
|
|
[submodule "vendor/nim-task-runner"]
|
|
|
|
|
path = vendor/nim-task-runner
|
|
|
|
|
url = https://github.com/status-im/nim-task-runner.git
|
|
|
|
|
[submodule "vendor/edn.nim"]
|
|
|
|
|
path = vendor/edn.nim
|
|
|
|
|
url = https://github.com/status-im/edn.nim.git
|
