mirror of
https://github.com/status-im/spiff-arena.git
synced 2025-01-15 04:34:16 +00:00
35ef5cbe54
1f51db962 Merge pull request #283 from sartography/feature/better_errors 69fb4967e Patching up some bugs and logical disconnects as I test out the errors. cf5be0096 * Making a few more things consistent in the error messages -- so there isn't filename for validation errors, and file_name for WorkflowExceptions. Same for line_number vs sourceline. * Assure than an error_type is consistently set on exceptions. * ValidationExceptions should not bild up a detailed error message that replicates information available within it. 440ee16c8 Responding to some excellent suggestions from Elizabeth: 655e415e1 Merge pull request #282 from subhakarks/fix-workfowspec-dump 1f6d3cf4e Explain that the error happened in a pre-script or post script. 8119abd14 Added a top level SpiffWorklowException that all exceptions inherit from. Aside from a message string you can append information to these exceptions with "add_note", which is a new method that all exceptions have starting in python 3.11 Switched arguments to the WorkflowException, WorkflowTaskException - which now always takes a string message as the first argument, and named arguments thereafter to be consistent with all other error messages in Python. Consistently raise ValidationExceptions whenever we encounter an error anywhere during parsing of xml. The BPMN/WorkflowTaskExecException is removed, in favor of just calling a WorkflowTaskException. There is nothing BPMN Specific in the logic, so no need for this. Consolidated error message logic so that things like "Did you mean" just get added by default if possible. So we don't have to separately deal with that logic each time. Better Error messages for DMN (include row number as a part of the error information) 13463b5c5 fix for workflowspec dump be26100bc Merge pull request #280 from sartography/feature/remove-unused-bpmn-attributes-and-methods 23a5c1d70 remove 'entering_* methods 4e5875ec8 remove sequence flow 5eed83ab1 Merge pull request #278 from sartography/feature/remove-old-serializer 614f1c68a remove compact serializer and references e7e410d4a remove old serializer and references git-subtree-dir: SpiffWorkflow git-subtree-split: 1f51db962ccaed5810f5d0f7d76a932f056430ab
74 lines
2.8 KiB
Python
74 lines
2.8 KiB
Python
# -*- coding: utf-8 -*-
|
|
|
|
# Copyright (C) 2021 Sartography
|
|
#
|
|
# This library is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU Lesser General Public
|
|
# License as published by the Free Software Foundation; either
|
|
# version 2.1 of the License, or (at your option) any later version.
|
|
#
|
|
# This library is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
# Lesser General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU Lesser General Public
|
|
# License along with this library; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
|
|
# 02110-1301 USA
|
|
|
|
|
|
from .base import TaskSpec
|
|
from ..task import TaskState
|
|
from SpiffWorkflow.exceptions import WorkflowTaskException
|
|
|
|
|
|
class LoopResetTask(TaskSpec):
|
|
|
|
"""
|
|
This task is used as a placeholder when we are going to loopback
|
|
to a previous point in the workflow. When this task is completed,
|
|
it will reset the workflow back to a previous point.
|
|
"""
|
|
|
|
def __init__(self, wf_spec, name, destination_id, destination_spec_name, **kwargs):
|
|
"""
|
|
Constructor.
|
|
|
|
:param script: the script that must be executed by the script engine.
|
|
"""
|
|
super(LoopResetTask, self).__init__(wf_spec, name, **kwargs)
|
|
self.destination_id = destination_id
|
|
self.destination_spec_name = destination_spec_name
|
|
|
|
def _on_complete_hook(self, task):
|
|
try:
|
|
# Prefer the exact task id, but if not available, use the
|
|
# last instance of the task_spec.
|
|
destination = task.workflow.get_task(self.destination_id)
|
|
if not destination:
|
|
destination = task.workflow.get_tasks_from_spec_name(
|
|
self.destination_spec_name)[-1]
|
|
|
|
destination.reset_token(task.data, reset_data=False)
|
|
except Exception as e:
|
|
# set state to WAITING (because it is definitely not COMPLETED)
|
|
# and raise WorkflowException pointing to this task because
|
|
# maybe upstream someone will be able to handle this situation
|
|
task._set_state(TaskState.WAITING)
|
|
if isinstance(e, WorkflowTaskException):
|
|
e.add_note('Error occurred during a loop back to a previous step.')
|
|
raise e
|
|
else:
|
|
raise WorkflowTaskException(
|
|
'Error during loop back:' + str(e), task=task, exception=e)
|
|
super(LoopResetTask, self)._on_complete_hook(task)
|
|
|
|
def serialize(self, serializer):
|
|
return serializer.serialize_loop_reset_task(self)
|
|
|
|
@classmethod
|
|
def deserialize(cls, serializer, wf_spec, s_state):
|
|
return serializer.deserialize_loop_reset_task(wf_spec, s_state)
|
|
|