mirror of
https://github.com/status-im/spiff-arena.git
synced 2025-01-15 12:44:52 +00:00
35ef5cbe54
1f51db962 Merge pull request #283 from sartography/feature/better_errors 69fb4967e Patching up some bugs and logical disconnects as I test out the errors. cf5be0096 * Making a few more things consistent in the error messages -- so there isn't filename for validation errors, and file_name for WorkflowExceptions. Same for line_number vs sourceline. * Assure than an error_type is consistently set on exceptions. * ValidationExceptions should not bild up a detailed error message that replicates information available within it. 440ee16c8 Responding to some excellent suggestions from Elizabeth: 655e415e1 Merge pull request #282 from subhakarks/fix-workfowspec-dump 1f6d3cf4e Explain that the error happened in a pre-script or post script. 8119abd14 Added a top level SpiffWorklowException that all exceptions inherit from. Aside from a message string you can append information to these exceptions with "add_note", which is a new method that all exceptions have starting in python 3.11 Switched arguments to the WorkflowException, WorkflowTaskException - which now always takes a string message as the first argument, and named arguments thereafter to be consistent with all other error messages in Python. Consistently raise ValidationExceptions whenever we encounter an error anywhere during parsing of xml. The BPMN/WorkflowTaskExecException is removed, in favor of just calling a WorkflowTaskException. There is nothing BPMN Specific in the logic, so no need for this. Consolidated error message logic so that things like "Did you mean" just get added by default if possible. So we don't have to separately deal with that logic each time. Better Error messages for DMN (include row number as a part of the error information) 13463b5c5 fix for workflowspec dump be26100bc Merge pull request #280 from sartography/feature/remove-unused-bpmn-attributes-and-methods 23a5c1d70 remove 'entering_* methods 4e5875ec8 remove sequence flow 5eed83ab1 Merge pull request #278 from sartography/feature/remove-old-serializer 614f1c68a remove compact serializer and references e7e410d4a remove old serializer and references git-subtree-dir: SpiffWorkflow git-subtree-split: 1f51db962ccaed5810f5d0f7d76a932f056430ab
228 lines
8.5 KiB
Python
228 lines
8.5 KiB
Python
# -*- coding: utf-8 -*-
|
|
import ast
|
|
import copy
|
|
import sys
|
|
import traceback
|
|
|
|
from ..exceptions import SpiffWorkflowException, WorkflowTaskException
|
|
from ..operators import Operator
|
|
|
|
|
|
# Copyright (C) 2020 Kelly McDonald
|
|
#
|
|
# This library is free software; you can redistribute it and/or
|
|
# modify it under the terms of the GNU Lesser General Public
|
|
# License as published by the Free Software Foundation; either
|
|
# version 2.1 of the License, or (at your option) any later version.
|
|
#
|
|
# This library is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
# Lesser General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU Lesser General Public
|
|
# License along with this library; if not, write to the Free Software
|
|
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
|
|
# 02110-1301 USA
|
|
|
|
|
|
class Box(dict):
|
|
"""
|
|
Example:
|
|
m = Box({'first_name': 'Eduardo'}, last_name='Pool', age=24, sports=['Soccer'])
|
|
"""
|
|
|
|
def __init__(self, *args, **kwargs):
|
|
super(Box, self).__init__(*args, **kwargs)
|
|
for arg in args:
|
|
if isinstance(arg, dict):
|
|
for k, v in arg.items():
|
|
if isinstance(v, dict):
|
|
self[k] = Box(v)
|
|
else:
|
|
self[k] = v
|
|
|
|
if kwargs:
|
|
for k, v in kwargs.items():
|
|
if isinstance(v, dict):
|
|
self[k] = Box(v)
|
|
else:
|
|
self[k] = v
|
|
|
|
def __deepcopy__(self, memodict=None):
|
|
if memodict is None:
|
|
memodict = {}
|
|
my_copy = Box()
|
|
for k, v in self.items():
|
|
my_copy[k] = copy.deepcopy(v)
|
|
return my_copy
|
|
|
|
def __getattr__(self, attr):
|
|
try:
|
|
output = self[attr]
|
|
except:
|
|
raise AttributeError(
|
|
"Dictionary has no attribute '%s' " % str(attr))
|
|
return output
|
|
|
|
def __setattr__(self, key, value):
|
|
self.__setitem__(key, value)
|
|
|
|
def __setitem__(self, key, value):
|
|
super(Box, self).__setitem__(key, value)
|
|
self.__dict__.update({key: value})
|
|
|
|
def __getstate__(self):
|
|
return self.__dict__
|
|
|
|
def __setstate__(self, state):
|
|
self.__init__(state)
|
|
|
|
def __delattr__(self, item):
|
|
self.__delitem__(item)
|
|
|
|
def __delitem__(self, key):
|
|
super(Box, self).__delitem__(key)
|
|
del self.__dict__[key]
|
|
|
|
|
|
class PythonScriptEngine(object):
|
|
"""
|
|
This should serve as a base for all scripting & expression evaluation
|
|
operations that are done within both BPMN and BMN. Eventually it will also
|
|
serve as a base for FEEL expressions as well
|
|
|
|
If you are uncomfortable with the use of eval() and exec, then you should
|
|
provide a specialised subclass that parses and executes the scripts /
|
|
expressions in a different way.
|
|
"""
|
|
|
|
def __init__(self, default_globals=None, scripting_additions=None):
|
|
|
|
self.globals = default_globals or {}
|
|
self.globals.update(scripting_additions or {})
|
|
self.error_tasks = {}
|
|
|
|
def validate(self, expression):
|
|
ast.parse(expression)
|
|
|
|
def evaluate(self, task, expression, external_methods=None):
|
|
"""
|
|
Evaluate the given expression, within the context of the given task and
|
|
return the result.
|
|
"""
|
|
try:
|
|
if isinstance(expression, Operator):
|
|
# I am assuming that this takes care of some kind of XML
|
|
# expression judging from the contents of operators.py
|
|
return expression._matches(task)
|
|
else:
|
|
return self._evaluate(expression, task.data, external_methods)
|
|
except SpiffWorkflowException as se:
|
|
se.add_note(f"Error evaluating expression '{expression}'")
|
|
raise se
|
|
except Exception as e:
|
|
raise WorkflowTaskException(f"Error evaluating expression '{expression}'", task=task, exception=e)
|
|
|
|
def execute(self, task, script, external_methods=None):
|
|
"""
|
|
Execute the script, within the context of the specified task
|
|
"""
|
|
try:
|
|
self.check_for_overwrite(task, external_methods or {})
|
|
self._execute(script, task.data, external_methods or {})
|
|
except Exception as err:
|
|
wte = self.create_task_exec_exception(task, script, err)
|
|
self.error_tasks[task.id] = wte
|
|
raise wte
|
|
|
|
def call_service(self, operation_name, operation_params, task_data):
|
|
"""Override to control how external services are called from service
|
|
tasks."""
|
|
raise NotImplementedError("To call external services override the script engine and implement `call_service`.")
|
|
|
|
def create_task_exec_exception(self, task, script, err):
|
|
line_number, error_line = self.get_error_line_number_and_content(script, err)
|
|
if isinstance(err, SpiffWorkflowException):
|
|
err.line_number = line_number
|
|
err.error_line = error_line
|
|
err.add_note(f"Python script error on line {line_number}: '{error_line}'")
|
|
return err
|
|
detail = err.__class__.__name__
|
|
if len(err.args) > 0:
|
|
detail += ":" + err.args[0]
|
|
return WorkflowTaskException(detail, task=task, exception=err, line_number=line_number, error_line=error_line)
|
|
|
|
def get_error_line_number_and_content(self, script, err):
|
|
line_number = 0
|
|
error_line = ''
|
|
if isinstance(err, SyntaxError):
|
|
line_number = err.lineno
|
|
else:
|
|
cl, exc, tb = sys.exc_info()
|
|
# Loop back through the stack trace to find the file called
|
|
# 'string' - which is the script we are executing, then use that
|
|
# to parse and pull out the offending line.
|
|
for frame_summary in traceback.extract_tb(tb):
|
|
if frame_summary.filename == '<string>':
|
|
line_number = frame_summary.lineno
|
|
if line_number > 0:
|
|
error_line = script.splitlines()[line_number - 1]
|
|
return line_number, error_line
|
|
|
|
def check_for_overwrite(self, task, external_methods):
|
|
"""It's possible that someone will define a variable with the
|
|
same name as a pre-defined script, rending the script un-callable.
|
|
This results in a nearly indecipherable error. Better to fail
|
|
fast with a sensible error message."""
|
|
func_overwrites = set(self.globals).intersection(task.data)
|
|
func_overwrites.update(set(external_methods).intersection(task.data))
|
|
if len(func_overwrites) > 0:
|
|
msg = f"You have task data that overwrites a predefined " \
|
|
f"function(s). Please change the following variable or " \
|
|
f"field name(s) to something else: {func_overwrites}"
|
|
raise WorkflowTaskException(msg, task=task)
|
|
|
|
def convert_to_box(self, data):
|
|
if isinstance(data, dict):
|
|
for key, value in data.items():
|
|
if not isinstance(value, Box):
|
|
data[key] = self.convert_to_box(value)
|
|
return Box(data)
|
|
if isinstance(data, list):
|
|
for idx, value in enumerate(data):
|
|
data[idx] = self.convert_to_box(value)
|
|
return data
|
|
return data
|
|
|
|
def _evaluate(self, expression, context, external_methods=None):
|
|
|
|
globals = copy.copy(self.globals) # else we pollute all later evals.
|
|
self.convert_to_box(context)
|
|
globals.update(external_methods or {})
|
|
globals.update(context)
|
|
return eval(expression, globals)
|
|
|
|
def _execute(self, script, context, external_methods=None):
|
|
|
|
my_globals = copy.copy(self.globals)
|
|
self.convert_to_box(context)
|
|
my_globals.update(external_methods or {})
|
|
context.update(my_globals)
|
|
try:
|
|
exec(script, context)
|
|
finally:
|
|
self.remove_globals_and_functions_from_context(context,
|
|
external_methods)
|
|
|
|
def remove_globals_and_functions_from_context(self, context,
|
|
external_methods=None):
|
|
"""When executing a script, don't leave the globals, functions
|
|
and external methods in the context that we have modified."""
|
|
for k in list(context):
|
|
if k == "__builtins__" or \
|
|
hasattr(context[k], '__call__') or \
|
|
k in self.globals or \
|
|
external_methods and k in external_methods:
|
|
context.pop(k)
|