From cd6a7f58060d07d9dceaed5865a532db53563f90 Mon Sep 17 00:00:00 2001
From: Dan <daniel.h.funk@gmail.com>
Date: Fri, 10 Mar 2023 12:56:37 -0500
Subject: [PATCH] Fixing Cypress Tests

---
 spiffworkflow-frontend/cypress.config.js                    | 2 +-
 spiffworkflow-frontend/cypress/e2e/process_instances.cy.js  | 2 +-
 spiffworkflow-frontend/cypress/e2e/process_models.cy.js     | 2 +-
 spiffworkflow-frontend/cypress/e2e/tasks.cy.js              | 6 +++---
 .../src/components/ProcessInstanceListTable.tsx             | 1 +
 5 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/spiffworkflow-frontend/cypress.config.js b/spiffworkflow-frontend/cypress.config.js
index f7f7b48c..5dc0a4f3 100644
--- a/spiffworkflow-frontend/cypress.config.js
+++ b/spiffworkflow-frontend/cypress.config.js
@@ -32,7 +32,7 @@ if (process.env.SPIFFWORKFLOW_FRONTEND_URL) {
 
 const cypressConfig = {
   projectId: 'crax1q',
-
+  defaultCommandTimeout: 10000,
   videoUploadOnPasses: false,
   chromeWebSecurity: false,
   e2e: {
diff --git a/spiffworkflow-frontend/cypress/e2e/process_instances.cy.js b/spiffworkflow-frontend/cypress/e2e/process_instances.cy.js
index 846d4162..64e0418a 100644
--- a/spiffworkflow-frontend/cypress/e2e/process_instances.cy.js
+++ b/spiffworkflow-frontend/cypress/e2e/process_instances.cy.js
@@ -158,7 +158,7 @@ describe('process-instances', () => {
     // make sure we have some process instances
     cy.runPrimaryBpmnFile();
     cy.getBySel('process-instance-list-link').click();
-    cy.getBySel('process-instance-show-link').first().click();
+    cy.getBySel('process-instance-show-link-id').first().click();
     cy.getBySel('process-instance-log-list-link').click();
     cy.getBySel('process-instance-log-detailed').click();
     cy.contains('process_model_one');
diff --git a/spiffworkflow-frontend/cypress/e2e/process_models.cy.js b/spiffworkflow-frontend/cypress/e2e/process_models.cy.js
index 0e925046..9e7bd55d 100644
--- a/spiffworkflow-frontend/cypress/e2e/process_models.cy.js
+++ b/spiffworkflow-frontend/cypress/e2e/process_models.cy.js
@@ -168,7 +168,7 @@ describe('process-models', () => {
       .click();
     cy.runPrimaryBpmnFile();
 
-    cy.getBySel('process-instance-show-link').click();
+    cy.getBySel('process-instance-show-link-id').click();
     cy.getBySel('process-instance-delete').click();
     cy.contains('Are you sure');
     cy.getBySel('process-instance-delete-modal-confirmation-dialog')
diff --git a/spiffworkflow-frontend/cypress/e2e/tasks.cy.js b/spiffworkflow-frontend/cypress/e2e/tasks.cy.js
index 922c4209..06e59d81 100644
--- a/spiffworkflow-frontend/cypress/e2e/tasks.cy.js
+++ b/spiffworkflow-frontend/cypress/e2e/tasks.cy.js
@@ -74,7 +74,7 @@ describe('tasks', () => {
     cy.assertAtLeastOneItemInPaginatedResults();
 
     // This should get the first one which should be the one we just completed
-    cy.getBySel('process-instance-show-link').first().click();
+    cy.getBySel('process-instance-show-link-id').first().click();
     cy.contains('Process Instance Id: ');
 
     cy.get(`g[data-element-id=form3]`).click();
@@ -106,7 +106,7 @@ describe('tasks', () => {
     cy.assertAtLeastOneItemInPaginatedResults();
 
     // This should get the first one which should be the one we just completed
-    cy.getBySel('process-instance-show-link').first().click();
+    cy.getBySel('process-instance-show-link-id').first().click();
     cy.contains('Process Instance Id: ');
     cy.contains('Status: complete');
   });
@@ -120,6 +120,6 @@ describe('tasks', () => {
     kickOffModelWithForm();
 
     cy.navigateToHome();
-    cy.basicPaginationTest('process-instance-show-link');
+    cy.basicPaginationTest('process-instance-show-link-id');
   });
 });
diff --git a/spiffworkflow-frontend/src/components/ProcessInstanceListTable.tsx b/spiffworkflow-frontend/src/components/ProcessInstanceListTable.tsx
index d4af460d..8c8f818f 100644
--- a/spiffworkflow-frontend/src/components/ProcessInstanceListTable.tsx
+++ b/spiffworkflow-frontend/src/components/ProcessInstanceListTable.tsx
@@ -1265,6 +1265,7 @@ export default function ProcessInstanceListTable({
       return (
         // eslint-disable-next-line jsx-a11y/no-noninteractive-element-interactions
         <td
+          data-qa={`process-instance-show-link-${column.accessor}`}
           onKeyDown={navigateToProcessModel}
           onClick={navigateToProcessInstance}
         >