From a795514570ebd77bd7fee6bd2fd743e6119473ec Mon Sep 17 00:00:00 2001 From: jasquat Date: Fri, 18 Nov 2022 14:36:54 -0500 Subject: [PATCH] moved model delete button to show page as an icon w/ burnettk --- .../src/components/ProcessModelForm.tsx | 18 -------- .../src/routes/ProcessModelShow.tsx | 41 +++++++++++++++++-- 2 files changed, 38 insertions(+), 21 deletions(-) diff --git a/spiffworkflow-frontend/src/components/ProcessModelForm.tsx b/spiffworkflow-frontend/src/components/ProcessModelForm.tsx index 15e4c270..d579d599 100644 --- a/spiffworkflow-frontend/src/components/ProcessModelForm.tsx +++ b/spiffworkflow-frontend/src/components/ProcessModelForm.tsx @@ -52,14 +52,6 @@ export default function ProcessModelForm({ return identifierToCheck.match(/^[a-z0-9][0-9a-z-]+[a-z0-9]$/); }; - const deleteProcessModel = () => { - HttpService.makeCallToBackend({ - path: `/process-models/${modifiedProcessModelPath}`, - successCallback: navigateToProcessModels, - httpMethod: 'DELETE', - }); - }; - const handleFormSubmission = (event: any) => { event.preventDefault(); let hasErrors = false; @@ -172,16 +164,6 @@ export default function ProcessModelForm({ Submit , ]; - if (mode === 'edit') { - buttons.push( - - ); - } return {buttons}; }; return ( diff --git a/spiffworkflow-frontend/src/routes/ProcessModelShow.tsx b/spiffworkflow-frontend/src/routes/ProcessModelShow.tsx index 549d964e..957a37e7 100644 --- a/spiffworkflow-frontend/src/routes/ProcessModelShow.tsx +++ b/spiffworkflow-frontend/src/routes/ProcessModelShow.tsx @@ -31,7 +31,10 @@ import { Can } from '@casl/react'; import ProcessBreadcrumb from '../components/ProcessBreadcrumb'; import HttpService from '../services/HttpService'; import ErrorContext from '../contexts/ErrorContext'; -import { modifyProcessModelPath } from '../helpers'; +import { + getGroupFromModifiedModelId, + modifyProcessModelPath, +} from '../helpers'; import { PermissionsToCheck, ProcessFile, @@ -106,7 +109,7 @@ export default function ProcessModelShow() { const { targetUris } = useUriListForPermissions(); const permissionRequestData: PermissionsToCheck = { - [targetUris.processModelShowPath]: ['PUT'], + [targetUris.processModelShowPath]: ['PUT', 'DELETE'], [targetUris.processInstanceListPath]: ['GET'], [targetUris.processInstanceActionPath]: ['POST'], [targetUris.processModelFileCreatePath]: ['POST', 'GET', 'DELETE'], @@ -251,6 +254,22 @@ export default function ProcessModelShow() { return null; }; + const navigateToProcessModels = (_result: any) => { + navigate( + `/admin/process-groups/${getGroupFromModifiedModelId( + modifiedProcessModelId + )}` + ); + }; + + const deleteProcessModel = () => { + HttpService.makeCallToBackend({ + path: `/process-models/${modifiedProcessModelId}`, + successCallback: navigateToProcessModels, + httpMethod: 'DELETE', + }); + }; + const navigateToFileEdit = (processModelFile: ProcessFile) => { const url = profileModelFileEditUrl(processModelFile); if (url) { @@ -529,7 +548,23 @@ export default function ProcessModelShow() { ], ]} /> -

Process Model: {processModel.display_name}

+ +

+ Process Model: {processModel.display_name} +

+ + + + +

{processModel.description}