From 6dc42aa273576802795f4768e2787a7430855519 Mon Sep 17 00:00:00 2001 From: jasquat Date: Thu, 23 Feb 2023 15:59:19 -0500 Subject: [PATCH 1/3] added api to get task data and do not return from task data list anymore w/ burnettk --- .../src/spiffworkflow_backend/api.yml | 39 ++++++ .../routes/process_instances_controller.py | 18 --- .../routes/tasks_controller.py | 122 ++++++++++++++++++ .../src/routes/ProcessInstanceShow.tsx | 30 ++++- 4 files changed, 185 insertions(+), 24 deletions(-) diff --git a/spiffworkflow-backend/src/spiffworkflow_backend/api.yml b/spiffworkflow-backend/src/spiffworkflow_backend/api.yml index 842491c2..d472d814 100755 --- a/spiffworkflow-backend/src/spiffworkflow_backend/api.yml +++ b/spiffworkflow-backend/src/spiffworkflow_backend/api.yml @@ -1559,6 +1559,39 @@ paths: items: $ref: "#/components/schemas/Task" + /task-data/{modified_process_model_identifier}/{process_instance_id}/{spiff_step}: + parameters: + - name: modified_process_model_identifier + in: path + required: true + description: The modified id of an existing process model + schema: + type: string + - name: process_instance_id + in: path + required: true + description: The unique id of an existing process instance. + schema: + type: integer + - name: spiff_step + in: path + required: true + description: If set will return the tasks as they were during a specific step of execution. + schema: + type: integer + get: + operationId: spiffworkflow_backend.routes.tasks_controller.task_data_show + summary: Get task data for a single task in a spiff step. + tags: + - Process Instances + responses: + "200": + description: list of tasks + content: + application/json: + schema: + $ref: "#/components/schemas/Task" + /task-data/{modified_process_model_identifier}/{process_instance_id}/{task_id}: parameters: - name: modified_process_model_identifier @@ -1579,6 +1612,12 @@ paths: description: The unique id of the task. schema: type: string + - name: spiff_step + in: query + required: false + description: If set will return the tasks as they were during a specific step of execution. + schema: + type: integer put: operationId: spiffworkflow_backend.routes.process_api_blueprint.task_data_update summary: Update the task data for requested instance and task diff --git a/spiffworkflow-backend/src/spiffworkflow_backend/routes/process_instances_controller.py b/spiffworkflow-backend/src/spiffworkflow_backend/routes/process_instances_controller.py index 4edbba04..d0df1a93 100644 --- a/spiffworkflow-backend/src/spiffworkflow_backend/routes/process_instances_controller.py +++ b/spiffworkflow-backend/src/spiffworkflow_backend/routes/process_instances_controller.py @@ -576,31 +576,15 @@ def process_instance_task_list( steps_by_id = {step_detail.task_id: step_detail for step_detail in step_details} - # FIXME: never evaluate task data in this call and instead create a new api getter - # that will return the task data for a given step only. We think processing this - # data is what is causing long load times on the processInstanceShowPage. subprocess_state_overrides = {} for step_detail in step_details: if step_detail.task_id in tasks: - task_data = ( - step_detail.task_json["task_data"] | step_detail.task_json["python_env"] - ) - if task_data is None: - task_data = {} - tasks[step_detail.task_id]["data"] = task_data tasks[step_detail.task_id]["state"] = Task.task_state_name_to_int( step_detail.task_state ) else: for subprocess_id, subprocess_info in subprocesses.items(): if step_detail.task_id in subprocess_info["tasks"]: - task_data = ( - step_detail.task_json["task_data"] - | step_detail.task_json["python_env"] - ) - if task_data is None: - task_data = {} - subprocess_info["tasks"][step_detail.task_id]["data"] = task_data subprocess_info["tasks"][step_detail.task_id]["state"] = ( Task.task_state_name_to_int(step_detail.task_state) ) @@ -657,8 +641,6 @@ def process_instance_task_list( calling_subprocess_task_id=calling_subprocess_task_id, task_spiff_step=task_spiff_step, ) - if get_task_data: - task.data = spiff_task.data tasks.append(task) return make_response(jsonify(tasks), 200) diff --git a/spiffworkflow-backend/src/spiffworkflow_backend/routes/tasks_controller.py b/spiffworkflow-backend/src/spiffworkflow_backend/routes/tasks_controller.py index c5dab954..eb836f49 100644 --- a/spiffworkflow-backend/src/spiffworkflow_backend/routes/tasks_controller.py +++ b/spiffworkflow-backend/src/spiffworkflow_backend/routes/tasks_controller.py @@ -36,6 +36,7 @@ from spiffworkflow_backend.models.human_task_user import HumanTaskUserModel from spiffworkflow_backend.models.process_instance import ProcessInstanceModel from spiffworkflow_backend.models.process_instance import ProcessInstanceStatus from spiffworkflow_backend.models.process_model import ProcessModelInfo +from spiffworkflow_backend.models.spiff_step_details import SpiffStepDetailsModel from spiffworkflow_backend.models.task import Task from spiffworkflow_backend.models.user import UserModel from spiffworkflow_backend.routes.process_api_blueprint import ( @@ -171,6 +172,127 @@ def task_list_for_my_groups( ) +def task_data_show( + modified_process_model_identifier: str, + process_instance_id: int, + spiff_step: int = 0, +) -> flask.wrappers.Response: + process_instance = _find_process_instance_by_id_or_raise(process_instance_id) + step_detail = ( + db.session.query(SpiffStepDetailsModel) + .filter( + SpiffStepDetailsModel.process_instance_id == process_instance.id, + SpiffStepDetailsModel.spiff_step == spiff_step, + ) + .first() + ) + + if step_detail is None: + raise ApiError( + error_code="spiff_step_for_proces_instance_not_found", + message=( + "The given spiff step for the given process instance could not be" + " found." + ), + status_code=400, + ) + + # step_details = step_detail_query.all() + # bpmn_json = json.loads(process_instance.bpmn_json or "{}") + # tasks = bpmn_json["tasks"] + # subprocesses = bpmn_json["subprocesses"] + # + # steps_by_id = {step_detail.task_id: step_detail for step_detail in step_details} + # + # # FIXME: never evaluate task data in this call and instead create a new api getter + # # that will return the task data for a given step only. We think processing this + # # data is what is causing long load times on the processInstanceShowPage. + # subprocess_state_overrides = {} + # if step_detail.task_id in tasks: + # task_data = ( + # step_detail.task_json["task_data"] | step_detail.task_json["python_env"] + # ) + # if task_data is None: + # task_data = {} + # tasks[step_detail.task_id]["data"] = task_data + # tasks[step_detail.task_id]["state"] = Task.task_state_name_to_int( + # step_detail.task_state + # ) + # else: + # for subprocess_id, subprocess_info in subprocesses.items(): + # if step_detail.task_id in subprocess_info["tasks"]: + # task_data = ( + # step_detail.task_json["task_data"] + # | step_detail.task_json["python_env"] + # ) + # if task_data is None: + # task_data = {} + # subprocess_info["tasks"][step_detail.task_id]["data"] = task_data + # subprocess_info["tasks"][step_detail.task_id]["state"] = ( + # Task.task_state_name_to_int(step_detail.task_state) + # ) + # subprocess_state_overrides[subprocess_id] = TaskState.WAITING + # + # for subprocess_info in subprocesses.values(): + # for spiff_task_id in subprocess_info["tasks"]: + # if spiff_task_id not in steps_by_id: + # subprocess_info["tasks"][spiff_task_id]["data"] = {} + # subprocess_info["tasks"][spiff_task_id]["state"] = ( + # subprocess_state_overrides.get(spiff_task_id, TaskState.FUTURE) + # ) + # for spiff_task_id in tasks: + # if spiff_task_id not in steps_by_id: + # tasks[spiff_task_id]["data"] = {} + # tasks[spiff_task_id]["state"] = subprocess_state_overrides.get( + # spiff_task_id, TaskState.FUTURE + # ) + # + # process_instance.bpmn_json = json.dumps(bpmn_json) + # + # processor = ProcessInstanceProcessor(process_instance) + # spiff_task = processor.__class__.get_task_by_bpmn_identifier( + # step_details[-1].bpmn_task_identifier, processor.bpmn_process_instance + # ) + # if spiff_task is not None and spiff_task.state != TaskState.READY: + # spiff_task.complete() + # + # spiff_tasks = None + # if all_tasks: + # spiff_tasks = processor.bpmn_process_instance.get_tasks(TaskState.ANY_MASK) + # else: + # spiff_tasks = processor.get_all_user_tasks() + # + # ( + # subprocesses_by_child_task_ids, + # task_typename_by_task_id, + # ) = processor.get_subprocesses_by_child_task_ids() + # processor.get_highest_level_calling_subprocesses_by_child_task_ids( + # subprocesses_by_child_task_ids, task_typename_by_task_id + # ) + # + # tasks = [] + # for spiff_task in spiff_tasks: + # task_spiff_step: Optional[int] = None + # if str(spiff_task.id) in steps_by_id: + # task_spiff_step = steps_by_id[str(spiff_task.id)].spiff_step + # calling_subprocess_task_id = subprocesses_by_child_task_ids.get( + # str(spiff_task.id), None + # ) + processor = ProcessInstanceProcessor(process_instance) + spiff_task = processor.__class__.get_task_by_bpmn_identifier( + step_detail.bpmn_task_identifier, processor.bpmn_process_instance + ) + task_data = step_detail.task_json["task_data"] | step_detail.task_json["python_env"] + task = ProcessInstanceService.spiff_task_to_api_task( + processor, + spiff_task, + task_spiff_step=spiff_step, + ) + task.data = task_data + + return make_response(jsonify(task), 200) + + def _munge_form_ui_schema_based_on_hidden_fields_in_task_data(task: Task) -> None: if task.form_ui_schema is None: task.form_ui_schema = {} diff --git a/spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx b/spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx index 297c9251..c9ab9875 100644 --- a/spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx +++ b/spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx @@ -65,7 +65,8 @@ export default function ProcessInstanceShow({ variant }: OwnProps) { useState(null); const [tasks, setTasks] = useState(null); const [tasksCallHadError, setTasksCallHadError] = useState(false); - const [taskToDisplay, setTaskToDisplay] = useState(null); + const [taskToDisplay, setTaskToDisplay] = + useState(null); const [taskDataToDisplay, setTaskDataToDisplay] = useState(''); const [processDataToDisplay, setProcessDataToDisplay] = useState(null); @@ -557,11 +558,23 @@ export default function ProcessInstanceShow({ variant }: OwnProps) { return
; }; - const initializeTaskDataToDisplay = (task: any) => { - if (task == null) { + const processTaskResult = (result: ProcessInstanceTask) => { + if (result == null) { setTaskDataToDisplay(''); } else { - setTaskDataToDisplay(JSON.stringify(task.data, null, 2)); + setTaskDataToDisplay(JSON.stringify(result.data, null, 2)); + } + }; + + const initializeTaskDataToDisplay = (task: ProcessInstanceTask | null) => { + if (task == null || task.state !== 'COMPLETED') { + setTaskDataToDisplay(''); + } else { + HttpService.makeCallToBackend({ + path: `/task-data/${params.process_model_id}/${params.process_instance_id}/${task.task_spiff_step}`, + httpMethod: 'GET', + successCallback: processTaskResult, + }); } }; @@ -742,8 +755,13 @@ export default function ProcessInstanceShow({ variant }: OwnProps) { const saveTaskDataResult = (_: any) => { setEditingTaskData(false); const dataObject = taskDataStringToObject(taskDataToDisplay); - const taskToDisplayCopy = { ...taskToDisplay, data: dataObject }; // spread operator - setTaskToDisplay(taskToDisplayCopy); + if (taskToDisplay) { + const taskToDisplayCopy: ProcessInstanceTask = { + ...taskToDisplay, + data: dataObject, + }; // spread operator + setTaskToDisplay(taskToDisplayCopy); + } refreshPage(); }; From 8463b2cda9ae66346c631cafa317b58daa16c5f0 Mon Sep 17 00:00:00 2001 From: jasquat Date: Thu, 23 Feb 2023 17:07:53 -0500 Subject: [PATCH 2/3] removed task-data endpoints since we no longer need them w/ burnettk --- .../src/spiffworkflow_backend/api.yml | 41 ------------------ .../routes/process_instances_controller.py | 20 --------- .../integration/test_process_api.py | 10 ++++- .../src/hooks/UriListForPermissions.tsx | 2 +- .../src/routes/ProcessInstanceShow.tsx | 43 ++++++++++++++----- 5 files changed, 41 insertions(+), 75 deletions(-) diff --git a/spiffworkflow-backend/src/spiffworkflow_backend/api.yml b/spiffworkflow-backend/src/spiffworkflow_backend/api.yml index d472d814..b9b7a9e3 100755 --- a/spiffworkflow-backend/src/spiffworkflow_backend/api.yml +++ b/spiffworkflow-backend/src/spiffworkflow_backend/api.yml @@ -1518,47 +1518,6 @@ paths: items: $ref: "#/components/schemas/Task" - /task-data/{modified_process_model_identifier}/{process_instance_id}: - parameters: - - name: modified_process_model_identifier - in: path - required: true - description: The modified id of an existing process model - schema: - type: string - - name: process_instance_id - in: path - required: true - description: The unique id of an existing process instance. - schema: - type: integer - - name: all_tasks - in: query - required: false - description: If true, this wil return all tasks associated with the process instance and not just user tasks. - schema: - type: boolean - - name: spiff_step - in: query - required: false - description: If set will return the tasks as they were during a specific step of execution. - schema: - type: integer - get: - tags: - - Process Instances - operationId: spiffworkflow_backend.routes.process_instances_controller.process_instance_task_list_with_task_data - summary: returns the list of all user tasks associated with process instance with the task data - responses: - "200": - description: list of tasks - content: - application/json: - schema: - type: array - items: - $ref: "#/components/schemas/Task" - /task-data/{modified_process_model_identifier}/{process_instance_id}/{spiff_step}: parameters: - name: modified_process_model_identifier diff --git a/spiffworkflow-backend/src/spiffworkflow_backend/routes/process_instances_controller.py b/spiffworkflow-backend/src/spiffworkflow_backend/routes/process_instances_controller.py index d0df1a93..6234c645 100644 --- a/spiffworkflow-backend/src/spiffworkflow_backend/routes/process_instances_controller.py +++ b/spiffworkflow-backend/src/spiffworkflow_backend/routes/process_instances_controller.py @@ -514,7 +514,6 @@ def process_instance_task_list_without_task_data_for_me( process_instance, all_tasks, spiff_step, - get_task_data=False, ) @@ -531,24 +530,6 @@ def process_instance_task_list_without_task_data( process_instance, all_tasks, spiff_step, - get_task_data=False, - ) - - -def process_instance_task_list_with_task_data( - modified_process_model_identifier: str, - process_instance_id: int, - all_tasks: bool = False, - spiff_step: int = 0, -) -> flask.wrappers.Response: - """Process_instance_task_list_with_task_data.""" - process_instance = _find_process_instance_by_id_or_raise(process_instance_id) - return process_instance_task_list( - modified_process_model_identifier, - process_instance, - all_tasks, - spiff_step, - get_task_data=True, ) @@ -557,7 +538,6 @@ def process_instance_task_list( process_instance: ProcessInstanceModel, all_tasks: bool = False, spiff_step: int = 0, - get_task_data: bool = False, ) -> flask.wrappers.Response: """Process_instance_task_list.""" step_detail_query = db.session.query(SpiffStepDetailsModel).filter( diff --git a/spiffworkflow-backend/tests/spiffworkflow_backend/integration/test_process_api.py b/spiffworkflow-backend/tests/spiffworkflow_backend/integration/test_process_api.py index a72796e0..95d42304 100644 --- a/spiffworkflow-backend/tests/spiffworkflow_backend/integration/test_process_api.py +++ b/spiffworkflow-backend/tests/spiffworkflow_backend/integration/test_process_api.py @@ -2766,8 +2766,14 @@ class TestProcessApi(BaseTest): headers=self.logged_in_headers(with_super_admin_user), ) assert response.status_code == 200 - end = next(task for task in response.json if task["type"] == "End Event") - assert end["data"]["result"] == {"message": "message 1"} + end_task = next(task for task in response.json if task["type"] == "End Event") + response = client.get( + f"/v1.0/task-data/{self.modify_process_identifier_for_path_param(process_model_identifier)}/{process_instance_id}/{end_task['task_spiff_step']}", + headers=self.logged_in_headers(with_super_admin_user), + ) + assert response.status_code == 200 + task = response.json + assert task["data"]["result"] == {"message": "message 1"} def test_manual_complete_task( self, diff --git a/spiffworkflow-frontend/src/hooks/UriListForPermissions.tsx b/spiffworkflow-frontend/src/hooks/UriListForPermissions.tsx index f8e5f07f..92fe3639 100644 --- a/spiffworkflow-frontend/src/hooks/UriListForPermissions.tsx +++ b/spiffworkflow-frontend/src/hooks/UriListForPermissions.tsx @@ -17,7 +17,7 @@ export const useUriListForPermissions = () => { processInstanceResumePath: `/v1.0/process-instance-resume/${params.process_model_id}/${params.process_instance_id}`, processInstanceSuspendPath: `/v1.0/process-instance-suspend/${params.process_model_id}/${params.process_instance_id}`, processInstanceResetPath: `/v1.0/process-instance-reset/${params.process_model_id}/${params.process_instance_id}`, - processInstanceTaskListDataPath: `/v1.0/task-data/${params.process_model_id}/${params.process_instance_id}`, + processInstanceTaskDataPath: `/v1.0/task-data/${params.process_model_id}/${params.process_instance_id}`, processInstanceSendEventPath: `/v1.0/send-event/${params.process_model_id}/${params.process_instance_id}`, processInstanceCompleteTaskPath: `/v1.0/complete-task/${params.process_model_id}/${params.process_instance_id}`, processInstanceTaskListPath: `/v1.0/process-instances/${params.process_model_id}/${params.process_instance_id}/task-info`, diff --git a/spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx b/spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx index c9ab9875..c538632e 100644 --- a/spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx +++ b/spiffworkflow-frontend/src/routes/ProcessInstanceShow.tsx @@ -27,6 +27,7 @@ import { Modal, Dropdown, Stack, + Loading, // @ts-ignore } from '@carbon/react'; import { Can } from '@casl/react'; @@ -68,6 +69,9 @@ export default function ProcessInstanceShow({ variant }: OwnProps) { const [taskToDisplay, setTaskToDisplay] = useState(null); const [taskDataToDisplay, setTaskDataToDisplay] = useState(''); + const [showTaskDataLoading, setShowTaskDataLoading] = + useState(false); + const [processDataToDisplay, setProcessDataToDisplay] = useState(null); const [editingTaskData, setEditingTaskData] = useState(false); @@ -100,7 +104,7 @@ export default function ProcessInstanceShow({ variant }: OwnProps) { [targetUris.messageInstanceListPath]: ['GET'], [targetUris.processInstanceActionPath]: ['DELETE'], [targetUris.processInstanceLogListPath]: ['GET'], - [targetUris.processInstanceTaskListDataPath]: ['GET', 'PUT'], + [targetUris.processInstanceTaskDataPath]: ['GET', 'PUT'], [targetUris.processInstanceSendEventPath]: ['POST'], [targetUris.processInstanceCompleteTaskPath]: ['POST'], [targetUris.processModelShowPath]: ['PUT'], @@ -146,9 +150,7 @@ export default function ProcessInstanceShow({ variant }: OwnProps) { taskParams = `${taskParams}&spiff_step=${params.spiff_step}`; } let taskPath = ''; - if (ability.can('GET', targetUris.processInstanceTaskListDataPath)) { - taskPath = `${targetUris.processInstanceTaskListDataPath}${taskParams}`; - } else if (ability.can('GET', taskListPath)) { + if (ability.can('GET', taskListPath)) { taskPath = `${taskListPath}${taskParams}`; } if (taskPath) { @@ -564,17 +566,27 @@ export default function ProcessInstanceShow({ variant }: OwnProps) { } else { setTaskDataToDisplay(JSON.stringify(result.data, null, 2)); } + setShowTaskDataLoading(false); }; const initializeTaskDataToDisplay = (task: ProcessInstanceTask | null) => { - if (task == null || task.state !== 'COMPLETED') { - setTaskDataToDisplay(''); - } else { + if ( + task && + task.state === 'COMPLETED' && + ability.can('GET', targetUris.processInstanceTaskDataPath) + ) { + setShowTaskDataLoading(true); HttpService.makeCallToBackend({ - path: `/task-data/${params.process_model_id}/${params.process_instance_id}/${task.task_spiff_step}`, + path: `${targetUris.processInstanceTaskDataPath}/${task.task_spiff_step}`, httpMethod: 'GET', successCallback: processTaskResult, + failureCallback: (error: any) => { + setTaskDataToDisplay(`ERROR: ${error.message}`); + setShowTaskDataLoading(false); + }, }); + } else { + setTaskDataToDisplay(''); } }; @@ -681,7 +693,7 @@ export default function ProcessInstanceShow({ variant }: OwnProps) { const canEditTaskData = (task: any) => { return ( processInstance && - ability.can('PUT', targetUris.processInstanceTaskListDataPath) && + ability.can('PUT', targetUris.processInstanceTaskDataPath) && isCurrentTask(task) && processInstance.status === 'suspended' && showingLastSpiffStep() @@ -775,7 +787,7 @@ export default function ProcessInstanceShow({ variant }: OwnProps) { // taskToUse is copy of taskToDisplay, with taskDataToDisplay in data attribute const taskToUse: any = { ...taskToDisplay, data: taskDataToDisplay }; HttpService.makeCallToBackend({ - path: `${targetUris.processInstanceTaskListDataPath}/${taskToUse.id}`, + path: `${targetUris.processInstanceTaskDataPath}/${taskToUse.id}`, httpMethod: 'PUT', successCallback: saveTaskDataResult, failureCallback: addError, @@ -919,6 +931,10 @@ export default function ProcessInstanceShow({ variant }: OwnProps) { }; const taskDataContainer = () => { + let taskDataClassName = ''; + if (taskDataToDisplay.startsWith('ERROR:')) { + taskDataClassName = 'failure-string'; + } return editingTaskData ? ( setTaskDataToDisplay(value || '')} /> ) : ( - 
{taskDataToDisplay}
+ <> + {showTaskDataLoading ? ( + + ) : null} + 
{taskDataToDisplay}
+ ); }; From 06c4af9e17434f7540efd820a87c2e255ba0ea65 Mon Sep 17 00:00:00 2001 From: jasquat Date: Thu, 23 Feb 2023 17:09:33 -0500 Subject: [PATCH 3/3] removed commented out code w/ burnettk --- .../routes/tasks_controller.py | 81 ------------------- 1 file changed, 81 deletions(-) diff --git a/spiffworkflow-backend/src/spiffworkflow_backend/routes/tasks_controller.py b/spiffworkflow-backend/src/spiffworkflow_backend/routes/tasks_controller.py index eb836f49..82fd8899 100644 --- a/spiffworkflow-backend/src/spiffworkflow_backend/routes/tasks_controller.py +++ b/spiffworkflow-backend/src/spiffworkflow_backend/routes/tasks_controller.py @@ -197,87 +197,6 @@ def task_data_show( status_code=400, ) - # step_details = step_detail_query.all() - # bpmn_json = json.loads(process_instance.bpmn_json or "{}") - # tasks = bpmn_json["tasks"] - # subprocesses = bpmn_json["subprocesses"] - # - # steps_by_id = {step_detail.task_id: step_detail for step_detail in step_details} - # - # # FIXME: never evaluate task data in this call and instead create a new api getter - # # that will return the task data for a given step only. We think processing this - # # data is what is causing long load times on the processInstanceShowPage. - # subprocess_state_overrides = {} - # if step_detail.task_id in tasks: - # task_data = ( - # step_detail.task_json["task_data"] | step_detail.task_json["python_env"] - # ) - # if task_data is None: - # task_data = {} - # tasks[step_detail.task_id]["data"] = task_data - # tasks[step_detail.task_id]["state"] = Task.task_state_name_to_int( - # step_detail.task_state - # ) - # else: - # for subprocess_id, subprocess_info in subprocesses.items(): - # if step_detail.task_id in subprocess_info["tasks"]: - # task_data = ( - # step_detail.task_json["task_data"] - # | step_detail.task_json["python_env"] - # ) - # if task_data is None: - # task_data = {} - # subprocess_info["tasks"][step_detail.task_id]["data"] = task_data - # subprocess_info["tasks"][step_detail.task_id]["state"] = ( - # Task.task_state_name_to_int(step_detail.task_state) - # ) - # subprocess_state_overrides[subprocess_id] = TaskState.WAITING - # - # for subprocess_info in subprocesses.values(): - # for spiff_task_id in subprocess_info["tasks"]: - # if spiff_task_id not in steps_by_id: - # subprocess_info["tasks"][spiff_task_id]["data"] = {} - # subprocess_info["tasks"][spiff_task_id]["state"] = ( - # subprocess_state_overrides.get(spiff_task_id, TaskState.FUTURE) - # ) - # for spiff_task_id in tasks: - # if spiff_task_id not in steps_by_id: - # tasks[spiff_task_id]["data"] = {} - # tasks[spiff_task_id]["state"] = subprocess_state_overrides.get( - # spiff_task_id, TaskState.FUTURE - # ) - # - # process_instance.bpmn_json = json.dumps(bpmn_json) - # - # processor = ProcessInstanceProcessor(process_instance) - # spiff_task = processor.__class__.get_task_by_bpmn_identifier( - # step_details[-1].bpmn_task_identifier, processor.bpmn_process_instance - # ) - # if spiff_task is not None and spiff_task.state != TaskState.READY: - # spiff_task.complete() - # - # spiff_tasks = None - # if all_tasks: - # spiff_tasks = processor.bpmn_process_instance.get_tasks(TaskState.ANY_MASK) - # else: - # spiff_tasks = processor.get_all_user_tasks() - # - # ( - # subprocesses_by_child_task_ids, - # task_typename_by_task_id, - # ) = processor.get_subprocesses_by_child_task_ids() - # processor.get_highest_level_calling_subprocesses_by_child_task_ids( - # subprocesses_by_child_task_ids, task_typename_by_task_id - # ) - # - # tasks = [] - # for spiff_task in spiff_tasks: - # task_spiff_step: Optional[int] = None - # if str(spiff_task.id) in steps_by_id: - # task_spiff_step = steps_by_id[str(spiff_task.id)].spiff_step - # calling_subprocess_task_id = subprocesses_by_child_task_ids.get( - # str(spiff_task.id), None - # ) processor = ProcessInstanceProcessor(process_instance) spiff_task = processor.__class__.get_task_by_bpmn_identifier( step_detail.bpmn_task_identifier, processor.bpmn_process_instance