status-im/spiff-arena
2
0
Fork 0
mirror of https://github.com/status-im/spiff-arena.git synced 2025-03-01 09:50:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

avoid dup artifact saving and fail fast if it does not upload

Browse Source
This commit is contained in:
burnettk 2024-02-02 13:43:01 -05:00
parent aed230626c
commit 80b6a006ec
No known key found for this signature in database
1 changed files with 5 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
.github/workflows/tests.yml vendored
View File

@ -304,14 +304,16 @@ jobs:
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
# part about saving PR number and then using it from auto-merge-dependabot-prs from: # part about saving PR number and then using it from auto-merge-dependabot-prs from:
# https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_run # https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_run
- name: Save PR number - name: Write PR number to spiffworkflow-backend/pr dir
if: ${{ github.event_name == 'pull_request' }} if: ${{ github.event_name == 'pull_request' }}
env: env:
PR_NUMBER: ${{ github.event.number }} PR_NUMBER: ${{ github.event.number }}
run: | run: |
mkdir -p ./pr mkdir -p ./pr
echo "$PR_NUMBER" > ./pr/pr_number echo "$PR_NUMBER" > ./pr/pr_number
- uses: actions/upload-artifact@v3 - name: Upload PR number as artifact
uses: actions/upload-artifact@v3
if: ${{ github.event_name == 'pull_request' }}
with: with:
name: pr_number name: pr_number
# at https://github.com/sartography/spiff-arena/actions/runs/7757308061/job/21156982087, for example, # at https://github.com/sartography/spiff-arena/actions/runs/7757308061/job/21156982087, for example,
@ -319,6 +321,7 @@ jobs:
# from spiff-arena root rather than the default working-directory we specified, and therefore # from spiff-arena root rather than the default working-directory we specified, and therefore
# trying to explicitly add spiffworkflow-backend to path # trying to explicitly add spiffworkflow-backend to path
path: spiffworkflow-backend/pr/ path: spiffworkflow-backend/pr/
if-no-files-found: error
tests-frontend: tests-frontend:
runs-on: ubuntu-latest runs-on: ubuntu-latest
@ -355,19 +358,6 @@ jobs:
env: env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
# part about saving PR number and then using it from auto-merge-dependabot-prs from:
# https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_run
- name: Save PR number
if: ${{ github.event_name == 'pull_request' }}
env:
PR_NUMBER: ${{ github.event.number }}
run: |
mkdir -p ./pr
echo "$PR_NUMBER" > ./pr/pr_number
- uses: actions/upload-artifact@v3
with:
name: pr_number
path: pr/
cypress-run: cypress-run:
runs-on: ubuntu-latest runs-on: ubuntu-latest