From 69c62cfdcb8cb91facd8bae28395be9c1f8df844 Mon Sep 17 00:00:00 2001
From: jasquat <jasquat@users.noreply.github.com>
Date: Wed, 30 Nov 2022 15:35:37 -0500
Subject: [PATCH] better display for failure causes on message list w/ burnettk

---
 spiffworkflow-frontend/src/index.css          | 12 +++++++
 .../src/routes/MessageInstanceList.tsx        | 34 ++++++++++++++++---
 2 files changed, 42 insertions(+), 4 deletions(-)

diff --git a/spiffworkflow-frontend/src/index.css b/spiffworkflow-frontend/src/index.css
index 53e04b78..ade073f5 100644
--- a/spiffworkflow-frontend/src/index.css
+++ b/spiffworkflow-frontend/src/index.css
@@ -72,15 +72,19 @@ h2 {
 /* match normal link colors */
 .cds--btn--ghost.button-link {
   color: #0062fe;
+  padding-left: 0;
 }
 .cds--btn--ghost.button-link:visited {
   color: #0062fe;
+  padding-left: 0;
 }
 .cds--btn--ghost.button-link:hover {
   color: #0062fe;
+  padding-left: 0;
 }
 .cds--btn--ghost.button-link:visited:hover {
   color: #0062fe;
+  padding-left: 0;
 }
 
 .cds--header__global .cds--btn--primary {
@@ -311,3 +315,11 @@ td.actions-cell {
   text-align: right;
   padding-bottom: 10px;
 }
+
+.cds--btn--ghost:not([disabled]) svg {
+  fill: red;
+}
+
+.failure-string {
+  color: red;
+}
diff --git a/spiffworkflow-frontend/src/routes/MessageInstanceList.tsx b/spiffworkflow-frontend/src/routes/MessageInstanceList.tsx
index 5a2d4e1a..b77b744c 100644
--- a/spiffworkflow-frontend/src/routes/MessageInstanceList.tsx
+++ b/spiffworkflow-frontend/src/routes/MessageInstanceList.tsx
@@ -1,5 +1,7 @@
 import { useEffect, useState } from 'react';
 // @ts-ignore
+import { ErrorOutline } from '@carbon/icons-react';
+// @ts-ignore
 import { Table, Modal, Button } from '@carbon/react';
 import { Link, useParams, useSearchParams } from 'react-router-dom';
 import PaginationForTable from '../components/PaginationForTable';
@@ -46,14 +48,27 @@ export default function MessageInstanceList() {
 
   const correlationsDisplayModal = () => {
     if (messageInstanceForModal) {
+      let failureCausePre = null;
+      if (messageInstanceForModal.failure_cause) {
+        failureCausePre = (
+          <>
+            <p className="failure-string">
+              {messageInstanceForModal.failure_cause}
+            </p>
+            <br />
+          </>
+        );
+      }
       return (
         <Modal
           open={!!messageInstanceForModal}
           passiveModal
           onRequestClose={handleCorrelationDisplayClose}
           modalHeading={`Message ${messageInstanceForModal.id} (${messageInstanceForModal.message_identifier}) ${messageInstanceForModal.message_type} data:`}
-          modalLabel="Correlations"
+          modalLabel="Details"
         >
+          {failureCausePre}
+          <p>Correlations:</p>
           <pre>
             {JSON.stringify(
               messageInstanceForModal.message_correlations,
@@ -69,6 +84,17 @@ export default function MessageInstanceList() {
 
   const buildTable = () => {
     const rows = messageIntances.map((row: MessageInstance) => {
+      let errorIcon = null;
+      let errorTitle = null;
+      if (row.failure_cause) {
+        errorTitle = 'Instance has an error';
+        errorIcon = (
+          <>
+            &nbsp;
+            <ErrorOutline className="red-icon" />
+          </>
+        );
+      }
       return (
         <tr key={row.id}>
           <td>{row.id}</td>
@@ -85,14 +111,15 @@ export default function MessageInstanceList() {
           </td>
           <td>{row.message_identifier}</td>
           <td>{row.message_type}</td>
-          <td>{row.failure_cause || '-'}</td>
           <td>
             <Button
               kind="ghost"
               className="button-link"
               onClick={() => setMessageInstanceForModal(row)}
+              title={errorTitle}
             >
               View
+              {errorIcon}
             </Button>
           </td>
           <td>{row.status}</td>
@@ -111,8 +138,7 @@ export default function MessageInstanceList() {
             <th>Process Instance</th>
             <th>Name</th>
             <th>Type</th>
-            <th>Failure Cause</th>
-            <th>Correlations</th>
+            <th>Details</th>
             <th>Status</th>
             <th>Created At</th>
           </tr>