From 2d80a80bd259f628d1f659d8f49c88ada293a7ec Mon Sep 17 00:00:00 2001 From: Jon Herron Date: Tue, 7 Mar 2023 09:53:19 -0500 Subject: [PATCH] Don't double encrypt when updating/add if not exists --- .../spiffworkflow_backend/routes/service_tasks_controller.py | 2 +- .../src/spiffworkflow_backend/services/secret_service.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spiffworkflow-backend/src/spiffworkflow_backend/routes/service_tasks_controller.py b/spiffworkflow-backend/src/spiffworkflow_backend/routes/service_tasks_controller.py index 61c8f6da..13df219a 100644 --- a/spiffworkflow-backend/src/spiffworkflow_backend/routes/service_tasks_controller.py +++ b/spiffworkflow-backend/src/spiffworkflow_backend/routes/service_tasks_controller.py @@ -43,7 +43,7 @@ def authentication_callback( """Authentication_callback.""" verify_token(request.args.get("token"), force_run=True) response = request.args["response"] - SecretService().update_secret( + SecretService.update_secret( f"{service}/{auth_method}", response, g.user.id, create_if_not_exists=True ) return redirect( diff --git a/spiffworkflow-backend/src/spiffworkflow_backend/services/secret_service.py b/spiffworkflow-backend/src/spiffworkflow_backend/services/secret_service.py index ea0b0e5a..cd8a28fd 100644 --- a/spiffworkflow-backend/src/spiffworkflow_backend/services/secret_service.py +++ b/spiffworkflow-backend/src/spiffworkflow_backend/services/secret_service.py @@ -68,9 +68,9 @@ class SecretService: create_if_not_exists: Optional[bool] = False, ) -> None: """Does this pass pre commit?""" - value = cls._encrypt(value) secret_model = SecretModel.query.filter(SecretModel.key == key).first() if secret_model: + value = cls._encrypt(value) secret_model.value = value db.session.add(secret_model) try: