status-im/spiff-arena
2
0
Fork 0
mirror of https://github.com/status-im/spiff-arena.git synced 2025-01-12 19:24:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

draft-data-save-fix (#1795)

Browse Source 
* search for the correct id when sending autosave events w/ burnettk

* added cypress test for draft data autosave w/ burnettk

* added comment w/ burnettk

---------

Co-authored-by: jasquat <jasquat@users.noreply.github.com>
This commit is contained in:
jasquat 2024-06-21 13:37:26 -04:00 committed by GitHub
parent 6ab89dab40
commit 2b0d550ecd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 22 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
spiffworkflow-frontend/cypress/e2e/tasks.cy.js
View File

@ -1,9 +1,24 @@
const submitInputIntoFormField = (taskName, fieldKey, fieldValue) => {
const submitInputIntoFormField = (
taskName,
fieldKey,
fieldValue,
checkDraftData,
) => {
cy.contains(`Task: ${taskName}`, { timeout: 10000 });
cy.get(fieldKey).clear();
cy.get(fieldKey).type(fieldValue);
// wait a little bit after typing for the debounce to take effect
cy.wait(100);
// after a bit of a debounce period, the site automatically saves the data the user has been entering in user task forms.
// if that doesn't work, it's not great.
// so to test that, we reload the page and make sure the data they entered is not lost.
if (checkDraftData) {
cy.wait(1000);
cy.reload();
cy.get(fieldKey).should('have.value', fieldValue);
}
cy.contains('Submit').click();
};
@ -19,7 +34,7 @@ const checkTaskHasClass = (taskName, className) => {
const kickOffModelWithForm = () => {
cy.navigateToProcessModel(
'Acceptance Tests Group One',
'Acceptance Tests Model 2'
'Acceptance Tests Model 2',
);
cy.runPrimaryBpmnFile(true);
};
@ -41,7 +56,7 @@ describe('tasks', () => {
cy.navigateToProcessModel(groupDisplayName, modelDisplayName);
cy.runPrimaryBpmnFile(true);
submitInputIntoFormField('get_form_num_one', '#root_form_num_1', 2);
submitInputIntoFormField('get_form_num_one', '#root_form_num_1', 2, true);
submitInputIntoFormField('get_form_num_two', '#root_form_num_2', 3);
cy.contains('Task: get_form_num_three');

5
spiffworkflow-frontend/src/routes/TaskShow.tsx
View File

@ -161,8 +161,11 @@ export default function TaskShow() {
};
const sendAutosaveEvent = (eventDetails?: any) => {
if (!taskWithTaskData) {
return;
}
const elementToDispath: any = document.getElementById(
'hidden-form-for-autosave',
`hidden-form-for-autosave-${taskWithTaskData.guid}`,
);
if (elementToDispath) {
elementToDispath.dispatchEvent(