status-im
/
spiff-arena
mirror of https://github.com/status-im/spiff-arena.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

don't flake out when no dmn options are returned.

This commit is contained in:
Dan 2022-11-09 11:39:57 -05:00
parent cab007fe41
commit 250a1a7327
2 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bpmn-js-spiffworkflow/app/spiffworkflow/extensions/propertiesPanel/SpiffExtensionSelect.js
View File

@ -46,9 +46,9 @@ export function SpiffExtensionSelect(props) {
if (
!(optionType in spiffExtensionOptions) ||
spiffExtensionOptions[optionType].length === 0
spiffExtensionOptions[optionType] === null
) {
spiffExtensionOptions[optionType] = [];
spiffExtensionOptions[optionType] = null;
requestOptions(eventBus, element, commandStack, optionType);
}
const getOptions = () => {

12
bpmn-js-spiffworkflow/test/spec/BusinessRulePropsSpec.js
View File

@ -33,8 +33,9 @@ describe('Business Rule Properties Panel', function () {
})
);
function addOptionsToEventBus(bpmnModeler) {
bpmnModeler.on('spiff.dmn_files.requested', (event) => {
const return_files = (event) => {
console.log("Return Files called.")
event.eventBus.fire('spiff.dmn_files.returned', {
options: [
{ label: 'Calculate Pizza Price', value: 'Decision_Pizza_Price' },
@ -42,14 +43,12 @@ describe('Business Rule Properties Panel', function () {
{ label: 'Test Decision', value: 'test_decision' },
],
});
});
}
it('should display a dropdown to select from available decision tables', async function () {
const modeler = getBpmnJS();
addOptionsToEventBus(modeler);
modeler.get('eventBus').once('spiff.dmn_files.requested', return_files);
expectSelected('business_rule_task');
// THEN - a properties panel exists with a section for editing that script
const entry = findEntry('extension_spiffworkflow:calledDecisionId', getPropertiesPanel());
expect(entry, 'No Entry').to.exist;
@ -60,7 +59,7 @@ describe('Business Rule Properties Panel', function () {
it('should update the spiffworkflow:calledDecisionId tag when you modify the called decision select box', async function () {
// IF - a script tag is selected, and you change the script in the properties panel
const modeler = getBpmnJS();
addOptionsToEventBus(modeler);
modeler.get('eventBus').once('spiff.dmn_files.requested', return_files);
const businessRuleTask = await expectSelected('business_rule_task');
const entry = findEntry('extension_calledDecisionId', getPropertiesPanel());
const selectList = findSelect(entry);
@ -85,4 +84,5 @@ describe('Business Rule Properties Panel', function () {
const element = businessObject.extensionElements.values[0];
expect(element.value).to.equal('test_decision');
});
});