From 98e91e2ad19b2ad043cb5477e7ef5f5cf2f1d67d Mon Sep 17 00:00:00 2001 From: Andrea Maria Piana Date: Tue, 21 Jan 2020 20:12:18 +0100 Subject: [PATCH] Apply suggestions from code review Co-Authored-By: Dean Eigenmann --- status-client-spec.md | 2 +- status-payloads-spec.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/status-client-spec.md b/status-client-spec.md index 3e7e80e..99992b6 100644 --- a/status-client-spec.md +++ b/status-client-spec.md @@ -69,7 +69,7 @@ Implementing a Status clients means implementing the following layers. Additiona ### Protobuf -We use `protobuf` in different layers, the version used is `proto3` unless stated otherwise. +We use [`protobuf`](https://developers.google.com/protocol-buffers/) in different layers, the version used is `proto3` unless stated otherwise. ## Components diff --git a/status-payloads-spec.md b/status-payloads-spec.md index b8ab3f3..4b0d275 100644 --- a/status-payloads-spec.md +++ b/status-payloads-spec.md @@ -179,7 +179,7 @@ The following messages types MUST be supported: Messages with a `clock` greater than `120` seconds over the whisper timestamp SHOULD be discarded, in order to avoid malicious users to increase the `clock` of a chat arbitrarily. -Messages with a `clock` less than `120` might indicate an attempt to insert messages in the chat history, this is not distinguishable though from a re-transmit from the `datasync` layer. Client MIGHT mark this messages with a warning to the user, or discard them. +Messages with a `clock` less than `120` might indicate an attempt to insert messages in the chat history, this is not distinguishable though from a re-transmit from the `datasync` layer. A client MAY mark this messages with a warning to the user, or discard them. `clock` value is used for the message ordering. Due to the used algorithm and distributed nature of the system, we achieve casual ordering which might produce counterintuitive results in some edge cases. For example, when one joins a public chat and sends a message before receiving the exist messages, their message `clock` value might be lower and the message will end up in the past when the historical messages are fetched.