mirror of
https://github.com/status-im/sourcecred.git
synced 2025-01-30 14:26:00 +00:00
f03e3c83f2
Our continuation-fetching code failed to properly get continuations for pull request review comments, because it was only asking for more reactions on `"IssueComment"` fragments. This caused the `ensureNoMorePages` function to properly throw an error rather than proceding with incomplete data. This commit fixes the root cause by splitting `continuationsFromComment`into `continuationsFromReviewComment` and `continuationsFromIssueComment`. (Pull and issue comments are both considered 'IssueComment's.) The example-github repository has been updated to include 10 reactions to a single review comment; the example-data was updated in this commit, and all reactions have been loaded. I've also added a `console.error` statement in `ensureNoMorePages`. This only triggers when the program is about to fail, and it's useful for debugging. Test plan: `yarn test --full` passes. Paired with @wchargin