mirror of
https://github.com/status-im/sourcecred.git
synced 2025-02-13 13:06:32 +00:00
Summary: This is a minimal patch to make the deploy script depend on the separate, well-tested build script introduced in #592. The patch suggests a number of improvements that can be made to the deploy script itself, but I’m deferring those as they’re not on the critical path. These are tracked at #610. Test Plan: Apply the below patch. Then run `./scripts/deploy.sh -n`, and verify that the served output is correct, including the CNAME file. Verify that when the `DEPLOY_CNAME_URL` default value is removed, the resulting output does _not_ have a CNAME file. Patch, for ease of building: ```diff diff --git a/scripts/deploy.sh b/scripts/deploy.sh index cddcece..8925e5b 100755 --- a/scripts/deploy.sh +++ b/scripts/deploy.sh @@ -23,7 +23,7 @@ main() { preview_dir= trap cleanup EXIT - ensure_clean_working_tree + #ensure_clean_working_tree build_and_deploy } @@ -76,8 +76,7 @@ build_and_deploy() { "${sourcecred_repo}/scripts/build_static_site.sh" \ --target "${static_site}" \ ${DEPLOY_CNAME_URL:+--cname "${DEPLOY_CNAME_URL}"} \ - --repo ipfs/js-ipfs \ - --repo sourcecred/sourcecred \ + --repo sourcecred/example-github \ ; sourcecred_site="$(mktemp -d --suffix ".sourcecred-site")" ``` wchargin-branch: deploy-via-build