sourcecred/scripts
William Chargin 47bec6cc10
Make `ensure-flow.sh` more precise and accurate (#259)
Summary:
This fixes two problems in the previous version:
  - A new JS file not checked into git, but with a `@flow` directive,
    would cause `ensure-flow` to fail, because one list of files was
    from `git grep` and the other was from `find`.
  - Only the hard-coded directories `src config scripts` were searched.

Now, we search all JS files checked into Git, except for some hard-coded
exceptions, namely `flow-typed`.

Test Plan:
  1. Add `foo.js`, not checked into Git. Note that `ensure-flow` passes.
  2. Add `@flow` to `foo.js`, and note that `ensure-flow` still passes.
  3. Remove `@flow` from `.eslintrc.js`, and note that `ensure-flow`
     fails and nicely prints the filename. (Note: this file is at the
     repository root.)
  4. Create a file `echo stuff >$'naughty\nfilename.js'`, and note that
     `ensure-flow` has the correct behavior in both positive and
     negative cases.

wchargin-branch: ensure-flow-improvements
2018-05-10 12:38:39 -07:00
..
backend.js Turn on flow for scripts/{backend,build,test}.js (#241) 2018-05-08 14:35:56 -07:00
build.js Turn on flow for scripts/{backend,build,test}.js (#241) 2018-05-08 14:35:56 -07:00
ensure-flow.sh Make `ensure-flow.sh` more precise and accurate (#259) 2018-05-10 12:38:39 -07:00
start.js Proxy Webpack dev server through to an API server (#245) 2018-05-08 16:09:37 -07:00
test.js Turn on flow for scripts/{backend,build,test}.js (#241) 2018-05-08 14:35:56 -07:00