3 Commits

Author SHA1 Message Date
William Chargin
222f4a0738
deps: upgrade flow-bin@^0.127.0 (#1881)
Summary:
One weird hack needs to be slightly amended; everything else still works
given recent changes to suppression comments.

Test Plan:
Running `yarn flow` passes as is, but fails if a suppression comment is
removed.

wchargin-branch: flow-v0.127.0
2020-06-21 21:39:32 -07:00
William Chargin
61d6d22c2f
flow: rename $ExpectFlowError to $FlowExpectedError (#1880)
Summary:
The latest versions of Flow restrict suppression comments to the fixed
names `$FlowExpectedError` or `$FlowFixMe`. This patch replaces uses of
our custom suppression comment with `$FlowExpectedError`, as we don’t
use suppressions to mean “fix me; need to add types later” but instead
as expected type errors in tests (almost exclusively).

Generated by changing the suppression in `.flowconfig` and then running:

```
git ls-files -z '*.js' |
    xargs -0 sed -i -e 's/\$ExpectFlowError/$FlowExpectedError/g'
```

To check the changes in non-test files, run

```
git show ':!*.test.js'
```

and note that all changes are in fact expected errors rather than TODOs.

Test Plan:
Check that `yarn flow` passes as is, but fails if a `$FlowExpectedError`
comment is deleted.

wchargin-branch: flow-standard-suppressions
2020-06-21 21:32:08 -07:00
Dandelion Mané
e256b73f3b
Attempt to fix CI flakes (#1243) (#1282)
This is my latest salvo in trying to fix the persistent CI flakes we've
been having. They center on flow failing with `Out of retries,
exiting!`. Here's a representative failure [1].

My approach here is based on a discussion in a [GitHub thread] which
suggests that setting `server.max_workers=1` in the config can fix it.
Unfortunately, since it's in the flowconfig and is not a command line
option, I needed to fork the flowconfig into a CI and non-CI version.

Test plan: Merge it, and see if the flake goes away.

[1]: https://circleci.com/gh/sourcecred/sourcecred/1609?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
[GitHub thread]: https://github.com/atlassian/react-beautiful-dnd/issues/1007
2019-08-13 18:22:03 +02:00