ConnectionRow now shows the connection score (#658)
Previously, the ConnectionRow showed the score of the node that was the source of the connection. I believe the UI will be more consistent and useful if it instead shows the connection score, i.e. how important that connection was to the node in scope. This combos well with PR #657. Test plan: The change is very simple, and covered by unit tests. I also verified the behavior by examining the cred explorer.
This commit is contained in:
parent
c890fe03b4
commit
e3a4d1f2b9
|
@ -56,7 +56,7 @@ export class ConnectionRow extends React.PureComponent<ConnectionRowProps> {
|
||||||
sharedProps,
|
sharedProps,
|
||||||
target,
|
target,
|
||||||
depth,
|
depth,
|
||||||
scoredConnection: {connection, source, sourceScore, connectionScore},
|
scoredConnection: {connection, source, connectionScore},
|
||||||
} = this.props;
|
} = this.props;
|
||||||
const {pnd, adapters} = sharedProps;
|
const {pnd, adapters} = sharedProps;
|
||||||
const {score: targetScore} = NullUtil.get(pnd.get(target));
|
const {score: targetScore} = NullUtil.get(pnd.get(target));
|
||||||
|
@ -72,7 +72,7 @@ export class ConnectionRow extends React.PureComponent<ConnectionRowProps> {
|
||||||
description={connectionView}
|
description={connectionView}
|
||||||
connectionProportion={connectionProportion}
|
connectionProportion={connectionProportion}
|
||||||
showPadding={false}
|
showPadding={false}
|
||||||
score={sourceScore}
|
score={connectionScore}
|
||||||
>
|
>
|
||||||
<NodeRow
|
<NodeRow
|
||||||
depth={depth + 1}
|
depth={depth + 1}
|
||||||
|
|
|
@ -107,9 +107,9 @@ describe("app/credExplorer/pagerankTable/Connection", () => {
|
||||||
const {row} = await setup();
|
const {row} = await setup();
|
||||||
expect(row.props().showPadding).toBe(false);
|
expect(row.props().showPadding).toBe(false);
|
||||||
});
|
});
|
||||||
it("with the sourceScore", async () => {
|
it("with the connection score", async () => {
|
||||||
const {row, scoredConnection} = await setup();
|
const {row, scoredConnection} = await setup();
|
||||||
expect(row.props().score).toBe(scoredConnection.sourceScore);
|
expect(row.props().score).toBe(scoredConnection.connectionScore);
|
||||||
});
|
});
|
||||||
it("with the connectionProportion", async () => {
|
it("with the connectionProportion", async () => {
|
||||||
const {row, target, scoredConnection, sharedProps} = await setup();
|
const {row, target, scoredConnection, sharedProps} = await setup();
|
||||||
|
|
|
@ -15,6 +15,7 @@ import * as NullUtil from "../../util/null";
|
||||||
export type ScoredConnection = {|
|
export type ScoredConnection = {|
|
||||||
+connection: Connection,
|
+connection: Connection,
|
||||||
+source: NodeAddressT,
|
+source: NodeAddressT,
|
||||||
|
// TODO(@decentralion): Consider removing this unused field
|
||||||
+sourceScore: number,
|
+sourceScore: number,
|
||||||
+connectionScore: number,
|
+connectionScore: number,
|
||||||
|};
|
|};
|
||||||
|
|
Loading…
Reference in New Issue