status-im/sourcecred
2
0
Fork 0
mirror of https://github.com/status-im/sourcecred.git synced 2025-02-10 03:34:15 +00:00
Code Issues Projects Releases Wiki Activity

Use MemoryLocalStore for existing tests (#525)

Browse Source 
Summary:
This resolves a TODO. It’s not urgent, but it’s good practice.

wchargin-branch: use-memory-local-store
This commit is contained in:
William Chargin 2018-07-24 19:19:53 -07:00 committed by GitHub
parent 0489ff8844
commit c0da12af6e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/app/credExplorer/App.test.js
View File

@ -2,7 +2,7 @@
import React from "react"; import React from "react";
import {shallow} from "enzyme"; import {shallow} from "enzyme";
import BrowserLocalStore from "../browserLocalStore"; import MemoryLocalStore from "../memoryLocalStore";
import {pagerank} from "../../core/attribution/pagerank"; import {pagerank} from "../../core/attribution/pagerank";
import {App} from "./App"; import {App} from "./App";
@ -97,14 +97,7 @@ function example() {
describe("app/credExplorer/App", () => { describe("app/credExplorer/App", () => {
function makeLocalStore() { function makeLocalStore() {
// TODO(@wchargin): This should be an in-memory implementation of return new MemoryLocalStore();
// LocalStore, not the browser version. This only works because the
// store is not actually needed for the shallow render to complete
// successfully.
return new BrowserLocalStore({
version: "1",
keyPrefix: "cred-explorer",
});
} }
it("renders with clean state", () => { it("renders with clean state", () => {
shallow(<App localStore={makeLocalStore()} />); shallow(<App localStore={makeLocalStore()} />);