status-im
/
sourcecred
mirror of https://github.com/status-im/sourcecred.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Elide assertValid & assertValidParts in production (#1017) 

This commit substantially improves SourceCred's performance in
production.

Measurement methodology: I create a new tab in Chrome, navigate to my local
prototypes, and select go-ipfs. I then turn on profiling, and click the
analyze button, and then turn off profiling when analysis is done. I
then go to the "bottom-up" tab in the JS analysis box on the bottom and
sort by "Total Time".

__Before this commit:__

|        fn        | total time | time as % |
|:---------------- | ----------:| ---------:|
| assertValid      |      815ms |      8.6% |
| assertValidParts |      261ms |      2.7% |

__After this commit:__

|        fn        | total time | time as % |
|:---------------- | ----------:| ---------:|
| assertValid      |       21ms |      0.2% |
| assertValidParts |       23ms |      0.3% |

Test plan: `yarn test`, also performance measurement as described above.

Fixes #1011.
This commit is contained in:
Dandelion Mané 2018-12-01 17:33:44 -08:00 committed by GitHub
parent 973a72fe46
commit bbe773bb67
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/core/address.js
View File

@ -126,9 +126,11 @@ export function makeAddressModule(options: Options): AddressModule<string> {
); );
function assertValid(address: Address, what?: string): void { function assertValid(address: Address, what?: string): void {
// TODO(perf): If this function becomes a bottleneck, consider // istanbul ignore if
// omitting it entirely in production. If this is undesirable, a if (process.env.NODE_ENV !== "test") {
// number of micro-optimizations can be made. // Catching invalid addresses in test code should be sufficient
return;
}
const prefix = what == null ? "" : `${what}: `; const prefix = what == null ? "" : `${what}: `;
if (address == null) { if (address == null) {
throw new Error(prefix + `expected ${name}, got: ${String(address)}`); throw new Error(prefix + `expected ${name}, got: ${String(address)}`);
@ -160,9 +162,11 @@ export function makeAddressModule(options: Options): AddressModule<string> {
parts: $ReadOnlyArray<string>, parts: $ReadOnlyArray<string>,
what?: string what?: string
): void { ): void {
// TODO(perf): If this function becomes a bottleneck, consider // istanbul ignore if
// omitting it entirely in production. If this is undesirable, a if (process.env.NODE_ENV !== "test") {
// number of micro-optimizations can be made. // Catching invalid parts in test code should be sufficient
return;
}
const prefix = what == null ? "" : `${what}: `; const prefix = what == null ? "" : `${what}: `;
if (parts == null) { if (parts == null) {
throw new Error( throw new Error(