status-im
/
sourcecred
mirror of https://github.com/status-im/sourcecred.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Use `edgeToParts` in the GitHub edge tests (#399) 

Test Plan:
Observe that the new snapshots are easier to read. Might as well make
sure that they encode the same data as the old snapshots, too. Note that
the backslash character no longer appears in this snapshot file. :-)

wchargin-branch: use-edgeToParts
This commit is contained in:
William Chargin 2018-06-19 15:55:10 -07:00 committed by GitHub
parent aac2fc6792
commit b9c01d13c9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 135 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

134
src/v3/plugins/github/__snapshots__/edges.test.js.snap
View File

@ -1,12 +1,138 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`plugins/github/edges createEdge works for authors edges 1`] = `"{address: EdgeAddress[\\"sourcecred\\",\\"github\\",\\"AUTHORS\\",\\"2\\",\\"USERLIKE\\",\\"decentralion\\",\\"4\\",\\"ISSUE\\",\\"sourcecred\\",\\"example-github\\",\\"2\\"], src: NodeAddress[\\"sourcecred\\",\\"github\\",\\"USERLIKE\\",\\"decentralion\\"], dst: NodeAddress[\\"sourcecred\\",\\"github\\",\\"ISSUE\\",\\"sourcecred\\",\\"example-github\\",\\"2\\"]}"`;
exports[`plugins/github/edges createEdge works for authors edges 1`] = `
Object {
"addressParts": Array [
"sourcecred",
"github",
"AUTHORS",
"2",
"USERLIKE",
"decentralion",
"4",
"ISSUE",
"sourcecred",
"example-github",
"2",
],
"dstParts": Array [
"sourcecred",
"github",
"ISSUE",
"sourcecred",
"example-github",
"2",
],
"srcParts": Array [
"sourcecred",
"github",
"USERLIKE",
"decentralion",
],
}
`;
exports[`plugins/github/edges createEdge works for has-parent edges 1`] = `"{address: EdgeAddress[\\"sourcecred\\",\\"github\\",\\"HAS_PARENT\\",\\"7\\",\\"COMMENT\\",\\"REVIEW\\",\\"sourcecred\\",\\"example-github\\",\\"5\\",\\"100313899\\",\\"171460198\\"], src: NodeAddress[\\"sourcecred\\",\\"github\\",\\"COMMENT\\",\\"REVIEW\\",\\"sourcecred\\",\\"example-github\\",\\"5\\",\\"100313899\\",\\"171460198\\"], dst: NodeAddress[\\"sourcecred\\",\\"github\\",\\"REVIEW\\",\\"sourcecred\\",\\"example-github\\",\\"5\\",\\"100313899\\"]}"`;
exports[`plugins/github/edges createEdge works for has-parent edges 1`] = `
Object {
"addressParts": Array [
"sourcecred",
"github",
"HAS_PARENT",
"7",
"COMMENT",
"REVIEW",
"sourcecred",
"example-github",
"5",
"100313899",
"171460198",
],
"dstParts": Array [
"sourcecred",
"github",
"REVIEW",
"sourcecred",
"example-github",
"5",
"100313899",
],
"srcParts": Array [
"sourcecred",
"github",
"COMMENT",
"REVIEW",
"sourcecred",
"example-github",
"5",
"100313899",
"171460198",
],
}
`;
exports[`plugins/github/edges createEdge works for merged-as edges 1`] = `"{address: EdgeAddress[\\"sourcecred\\",\\"github\\",\\"MERGED_AS\\",\\"4\\",\\"PULL\\",\\"sourcecred\\",\\"example-github\\",\\"5\\"], src: NodeAddress[\\"sourcecred\\",\\"github\\",\\"PULL\\",\\"sourcecred\\",\\"example-github\\",\\"5\\"], dst: NodeAddress[\\"git\\",\\"commit\\",\\"123\\"]}"`;
exports[`plugins/github/edges createEdge works for merged-as edges 1`] = `
Object {
"addressParts": Array [
"sourcecred",
"github",
"MERGED_AS",
"4",
"PULL",
"sourcecred",
"example-github",
"5",
],
"dstParts": Array [
"git",
"commit",
"123",
],
"srcParts": Array [
"sourcecred",
"github",
"PULL",
"sourcecred",
"example-github",
"5",
],
}
`;
exports[`plugins/github/edges createEdge works for reference edges 1`] = `"{address: EdgeAddress[\\"sourcecred\\",\\"github\\",\\"REFERENCES\\",\\"4\\",\\"ISSUE\\",\\"sourcecred\\",\\"example-github\\",\\"2\\",\\"4\\",\\"PULL\\",\\"sourcecred\\",\\"example-github\\",\\"5\\"], src: NodeAddress[\\"sourcecred\\",\\"github\\",\\"ISSUE\\",\\"sourcecred\\",\\"example-github\\",\\"2\\"], dst: NodeAddress[\\"sourcecred\\",\\"github\\",\\"PULL\\",\\"sourcecred\\",\\"example-github\\",\\"5\\"]}"`;
exports[`plugins/github/edges createEdge works for reference edges 1`] = `
Object {
"addressParts": Array [
"sourcecred",
"github",
"REFERENCES",
"4",
"ISSUE",
"sourcecred",
"example-github",
"2",
"4",
"PULL",
"sourcecred",
"example-github",
"5",
],
"dstParts": Array [
"sourcecred",
"github",
"PULL",
"sourcecred",
"example-github",
"5",
],
"srcParts": Array [
"sourcecred",
"github",
"ISSUE",
"sourcecred",
"example-github",
"2",
],
}
`;
exports[`plugins/github/edges snapshots as expected: authors 1`] = `
Object {

10
src/v3/plugins/github/edges.test.js
View File

@ -1,6 +1,6 @@
// @flow
import {NodeAddress, EdgeAddress, edgeToString} from "../../core/graph";
import {NodeAddress, EdgeAddress, edgeToParts} from "../../core/graph";
import {createEdge, fromRaw, toRaw} from "./edges";
import * as GE from "./edges";
import * as GN from "./nodes";
@ -65,7 +65,7 @@ describe("plugins/github/edges", () => {
describe("createEdge", () => {
it("works for authors edges", () => {
expect(
edgeToString(
edgeToParts(
createEdge.authors(nodeExamples.user(), nodeExamples.issue())
)
).toMatchSnapshot();
@ -73,12 +73,12 @@ describe("plugins/github/edges", () => {
it("works for merged-as edges", () => {
const commitAddress = NodeAddress.fromParts(["git", "commit", "123"]);
expect(
edgeToString(createEdge.mergedAs(nodeExamples.pull(), commitAddress))
edgeToParts(createEdge.mergedAs(nodeExamples.pull(), commitAddress))
).toMatchSnapshot();
});
it("works for has-parent edges", () => {
expect(
edgeToString(
edgeToParts(
createEdge.hasParent(
nodeExamples.reviewComment(),
nodeExamples.review()
@ -88,7 +88,7 @@ describe("plugins/github/edges", () => {
});
it("works for reference edges", () => {
expect(
edgeToString(
edgeToParts(
createEdge.references(nodeExamples.issue(), nodeExamples.pull())
)
).toMatchSnapshot();