status-im/sourcecred
2
0
Fork 0
mirror of https://github.com/status-im/sourcecred.git synced 2025-01-15 23:25:35 +00:00
Code Issues Projects Releases Wiki Activity

GitHub: assume installation token length of 40 (#1486)

Browse Source 
In the documentation 16 characters were displayed.
But testing showed we're typically seeing 40.

Fixes #1474
This commit is contained in:
Robin van Boven 2019-12-10 18:45:54 +01:00 committed by GitHub
parent ef3e1d6c48
commit a41eb71949
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/github/token.js
View File

@ -30,7 +30,7 @@ export function validateToken(token: string) {
); );
} }
if (hexCode.length != 16) { if (hexCode.length != 40) {
console.warn( console.warn(
`Warning: GitHub installation access token has an unexpected hexadecimal component ` + `Warning: GitHub installation access token has an unexpected hexadecimal component ` +
`length of ${hexCode.length}.` `length of ${hexCode.length}.`

4
src/plugins/github/token.test.js
View File

@ -59,7 +59,7 @@ describe("plugins/github/token", () => {
it("should accept an installation access token format", () => { it("should accept an installation access token format", () => {
// Given // Given
const token = "v1.1bfb713d900c4962"; const token = "v1.1bfb713d900c49621bfb713d900c49621bfb713d";
// When // When
validateToken(token); validateToken(token);
@ -70,7 +70,7 @@ describe("plugins/github/token", () => {
it("should warn when installation access token has an unexpected version", () => { it("should warn when installation access token has an unexpected version", () => {
// Given // Given
const token = "v5.1bfb713d900c4962"; const token = "v5.1bfb713d900c49621bfb713d900c49621bfb713d";
// When // When
validateToken(token); validateToken(token);