status-im/sourcecred
2
0
Fork 0
mirror of https://github.com/status-im/sourcecred.git synced 2025-02-28 12:10:30 +00:00
Code Issues Projects Releases Wiki Activity

homepage: remove misleading CSS import (#1045)

Browse Source 
Summary:
We use Aphrodite, not CSS imports, for styling. We do have a small
`index.css` file that is included during server-side rendering, and is
only referenced from `src/homepage/server.js`. But our `index.js` file
also has a superfluous `import "./style.css"`, which might suggest that
we support CSS imports more generally. This patch removes that import.

Thanks to @brianlitwin on Discord for pointing out that this might be
confusing.

Test Plan:
Verified that, under both `yarn start` and `yarn build`, the appearance
is the same, and the document still includes a `<style>` element with
the contents of `index.css` (which is included by `server.js`).

wchargin-branch: remove-css-import
This commit is contained in:
William Chargin 2019-01-09 23:22:20 -08:00 committed by GitHub
parent 6a010291df
commit 989d1f359f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/homepage/index.js
View File

@ -8,8 +8,6 @@ import createRelativeHistory from "../webutil/createRelativeHistory";
import App from "./App";
import createRouteDataFromEnvironment from "./createRouteDataFromEnvironment";
import "./index.css";
const target = document.getElementById("root");
if (target == null) {
throw new Error("Unable to find root element!");