Blacklist more problematic quasar interactions (#1335)
Blacklist more problematic quasar interactions Summary: Context: <https://github.com/sourcecred/sourcecred/issues/1256#issuecomment-526252852> Without also blacklisting the reaction, we hit an invariant violation in the relational view (reactions are expected to have exactly one author). Test Plan: Running `node ./bin/sourcecred.js load quasarframework/quasar-cli` now completes successfully (in about 2 minutes 40 seconds). It does emit a warning: ``` Issue[MDU6SXNzdWUzNDg0NjUzNDg=].reactions: unexpected null value ``` …because one of the reactions was blacklisted. But the relational view handles this correctly, it seems: timeline cred is still computed and renders without obvious error. wchargin-branch: blacklist-more-quasar
This commit is contained in:
parent
7d3d24e0ec
commit
5bcec38e5b
|
@ -10,6 +10,7 @@ export const BLACKLISTED_IDS: $ReadOnlyArray<ObjectId> = deepFreeze([
|
|||
"MDEyOk9yZ2FuaXphdGlvbjE3OTUyOTI1",
|
||||
"MDEyOk9yZ2FuaXphdGlvbjI5MTkzOTQ=",
|
||||
"MDEyOk9yZ2FuaXphdGlvbjEyNDE3MDI0",
|
||||
"MDEyOk9yZ2FuaXphdGlvbjQzMDkzODIw",
|
||||
// In this case, the bot used to be a user (@greenkeeper)
|
||||
"MDM6Qm90MjMwNDAwNzY=",
|
||||
// @dependabot also gives incosistent results (user vs bot)
|
||||
|
@ -18,6 +19,7 @@ export const BLACKLISTED_IDS: $ReadOnlyArray<ObjectId> = deepFreeze([
|
|||
"MDg6UmVhY3Rpb24yMTY3ODkyNQ==",
|
||||
"MDg6UmVhY3Rpb240NDMwMzQ1",
|
||||
"MDg6UmVhY3Rpb24xMDI4MzQxOA==",
|
||||
"MDg6UmVhY3Rpb24zNDUxNjA2MQ==",
|
||||
// Now org used to be a user (@nueko)
|
||||
"MDEyOk9yZ2FuaXphdGlvbjIxMzQ5NTM=",
|
||||
// Problematic interactions they did as a user: Thumbs up reactions.
|
||||
|
|
Loading…
Reference in New Issue