Make `ensure-flow.sh` more precise and accurate (#259)

Summary:
This fixes two problems in the previous version:
  - A new JS file not checked into git, but with a `@flow` directive,
    would cause `ensure-flow` to fail, because one list of files was
    from `git grep` and the other was from `find`.
  - Only the hard-coded directories `src config scripts` were searched.

Now, we search all JS files checked into Git, except for some hard-coded
exceptions, namely `flow-typed`.

Test Plan:
  1. Add `foo.js`, not checked into Git. Note that `ensure-flow` passes.
  2. Add `@flow` to `foo.js`, and note that `ensure-flow` still passes.
  3. Remove `@flow` from `.eslintrc.js`, and note that `ensure-flow`
     fails and nicely prints the filename. (Note: this file is at the
     repository root.)
  4. Create a file `echo stuff >$'naughty\nfilename.js'`, and note that
     `ensure-flow` has the correct behavior in both positive and
     negative cases.

wchargin-branch: ensure-flow-improvements
This commit is contained in:
William Chargin 2018-05-10 12:38:39 -07:00 committed by GitHub
parent 1901d471f3
commit 47bec6cc10
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions

View File

@ -1,7 +1,7 @@
#!/bin/bash #!/bin/sh
set -eu set -eu
comm -13 -z \ git grep -Fz --files-without-match -e '@flow' -e '@no-flow' -- '*.js' \
<(git grep -z --name-only -e @flow -e @no-flow | sort -z) \ | grep -zv '^flow-typed/' \
<(find src config scripts -name '*.js' -print0 | sort -z) \ | tr '\0' '\n' \
| tr '\0' '\n' \ | tee /dev/stderr \
| diff -u /dev/null - | diff -q /dev/null - >/dev/null