status-im/sourcecred
2
0
Fork 0
mirror of https://github.com/status-im/sourcecred.git synced 2025-02-26 19:20:35 +00:00
Code Issues Projects Releases Wiki Activity

Allow delay between GitHub queries (#626)

Browse Source 
Summary:
This patch considers an environment variable `GITHUB_DELAY_MS`. If the
value is set to a positive integer, a delay of the given number of
milliseconds will be incurred before each query to GitHub. This is to
decrease the probability of being rate-limited; see #350 for details.
This in turn unblocks us to load SourceCred data for larger
repositories.

The use of an environment variable is something of a hack to get this
off the ground. See #638 for long-term plans.

Test Plan:
Run `time node ./bin/sourcecred.js load sourcecred/example-github` with
varying values for `GITHUB_DELAY_MS`. Note that with the variable unset,
set to zero, set to a negative number, or set to a non-numeric value,
the job completes quickly; when the delay is set to `5000`, the job
takes an extra five seconds.

wchargin-branch: delay-github-queries
This commit is contained in:
William Chargin 2018-08-10 17:53:26 -07:00 committed by GitHub
parent 378f627a6f
commit 33763a9f35
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/github/fetchGithubRepo.js
View File

@ -49,7 +49,14 @@ export default function fetchGithubRepo(
const GITHUB_GRAPHQL_SERVER = "https://api.github.com/graphql";
function postQuery({body, variables}, token) {
async function postQuery({body, variables}, token): Promise<any> {
// TODO(#638): Find a more principled way to ingest this parameter.
const delayMs: number = parseInt(process.env.GITHUB_DELAY_MS || "0", 10) || 0;
await new Promise((resolve) => {
setTimeout(() => {
resolve();
}, delayMs);
});
const payload = {
query: stringify.body(body, inlineLayout()),
variables: variables,