status-im
/
sourcecred
mirror of https://github.com/status-im/sourcecred.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Turn on flow for config/env.js (#243) 

It was doing some clever array construction that added possible booleans
to the array, then filtered them out. To make the typing simpler for
Flow's inspection, we now only put string elements in the array.

Test plan: `yarn travis --full` passed, and the CLI still works.
This commit is contained in:
Dandelion Mané 2018-05-08 14:56:06 -07:00 committed by GitHub
parent 2e8653a3ee
commit 3166c2a56c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
config/env.js
View File

@ -1,4 +1,4 @@
// @no-flow
// @flow
const fs = require("fs");
const path = require("path");
const paths = require("./paths");
@ -20,9 +20,9 @@ var dotenvFiles = [
// Don't include `.env.local` for `test` environment
// since normally you expect tests to produce the same
// results for everyone
NODE_ENV !== "test" && `${paths.dotenv}.local`,
...(NODE_ENV !== "test" ? [`${paths.dotenv}.local`] : []),
paths.dotenv,
].filter(Boolean);
];
// Load environment variables from .env* files. Suppress warnings using silent
// if this file is missing. dotenv will never modify any environment variables
@ -59,7 +59,7 @@ process.env.NODE_PATH = (process.env.NODE_PATH || "")
// injected into the application via DefinePlugin in Webpack configuration.
const REACT_APP = /^REACT_APP_/i;
function getClientEnvironment(publicUrl) {
function getClientEnvironment(publicUrl /*: string */) {
const raw = Object.keys(process.env)
.filter((key) => REACT_APP.test(key))
.reduce(