status-im/sourcecred
2
0
Fork 0
mirror of https://github.com/status-im/sourcecred.git synced 2025-02-26 19:20:35 +00:00
Code Issues Projects Releases Wiki Activity

RepositorySelect tests verify no console errors (#545)

Browse Source 
We should really do this as a matter of course on all frontend testing.
Not sure what the right pattern is for ensuring that.

Test plan: Travis
This commit is contained in:
Dandelion Mané 2018-07-27 15:32:47 -07:00 committed by GitHub
parent ec5b76a83d
commit 294616b556
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/app/credExplorer/RepositorySelect.test.js
View File

@ -20,6 +20,14 @@ require("../testUtil").configureAphrodite();
describe("app/credExplorer/RepositorySelect", () => { describe("app/credExplorer/RepositorySelect", () => {
beforeEach(() => { beforeEach(() => {
fetch.resetMocks(); fetch.resetMocks();
// $ExpectFlowError
console.error = jest.fn();
// $ExpectFlowError
console.warn = jest.fn();
});
afterEach(() => {
expect(console.warn).not.toHaveBeenCalled();
expect(console.error).not.toHaveBeenCalled();
}); });
function mockRegistry(registry: RepoRegistry) { function mockRegistry(registry: RepoRegistry) {
@ -112,7 +120,7 @@ describe("app/credExplorer/RepositorySelect", () => {
const result = loadStatus(localStore); const result = loadStatus(localStore);
expect(fetch).toHaveBeenCalledTimes(1); expect(fetch).toHaveBeenCalledTimes(1);
expect(fetch).toHaveBeenCalledWith(REPO_REGISTRY_API); expect(fetch).toHaveBeenCalledWith(REPO_REGISTRY_API);
expect.assertions(5); expect.assertions(7);
return result.then((status) => { return result.then((status) => {
expect(status.type).toBe("VALID"); expect(status.type).toBe("VALID");
if (status.type !== "VALID") { if (status.type !== "VALID") {
@ -139,14 +147,14 @@ describe("app/credExplorer/RepositorySelect", () => {
}); });
it("returns FAILURE on invalid fetch response", () => { it("returns FAILURE on invalid fetch response", () => {
fetch.mockResponseOnce(JSON.stringify(["hello"])); fetch.mockResponseOnce(JSON.stringify(["hello"]));
expect.assertions(1); expect.assertions(3);
return loadStatus(testLocalStore()).then((status) => { return loadStatus(testLocalStore()).then((status) => {
expect(status).toEqual({type: "FAILURE"}); expect(status).toEqual({type: "FAILURE"});
}); });
}); });
it("returns FAILURE on fetch failure", () => { it("returns FAILURE on fetch failure", () => {
fetch.mockReject(new Error("some failure")); fetch.mockReject(new Error("some failure"));
expect.assertions(1); expect.assertions(3);
return loadStatus(testLocalStore()).then((status) => { return loadStatus(testLocalStore()).then((status) => {
expect(status).toEqual({type: "FAILURE"}); expect(status).toEqual({type: "FAILURE"});
}); });