Change `src/v3/` to `src/` and remove v3 naming (#474)

Test plan:
`git grep -i v3` only shows incidental hits in longer strings
`yarn travis --full` passes
`yarn backend` works
`yarn build` works
`yarn start` works
`node bin/sourcecred.js start` works
`node bin/sourcecred.js load sourcecred example-github` works

Paired with @wchargin

config/paths.js

@@ -36,9 +36,9 @@ function getServedPath() {
 module.exports = {
   dotenv: resolveApp(".env"),
   appBuild: resolveApp("build"),
-  appPublic: resolveApp("src/v3/app/public"),
-  appHtml: resolveApp("src/v3/app/public/index.html"),
-  appIndexJs: resolveApp("src/v3/app/index.js"),
+  appPublic: resolveApp("src/app/public"),
+  appHtml: resolveApp("src/app/public/index.html"),
+  appIndexJs: resolveApp("src/app/index.js"),
   appPackageJson: resolveApp("package.json"),
   appSrc: resolveApp("src"),
   yarnLockFile: resolveApp("yarn.lock"),
@@ -53,20 +53,18 @@ module.exports = {
   // source file, and the key will be the filename of the bundled entry
   // point within the build directory.
   backendEntryPoints: {
-    apiApp: resolveApp("src/v3/app/apiApp.js"),
+    apiApp: resolveApp("src/app/apiApp.js"),
     //
-    sourcecred: resolveApp("src/v3/cli/sourcecred.js"),
-    "commands/load": resolveApp("src/v3/cli/commands/load.js"),
-    "commands/start-v3": resolveApp("src/v3/cli/commands/start.js"),
+    sourcecred: resolveApp("src/cli/sourcecred.js"),
+    "commands/load": resolveApp("src/cli/commands/load.js"),
+    "commands/start": resolveApp("src/cli/commands/start.js"),
     //
-    fetchAndPrintGithubRepoV3: resolveApp(
-      "src/v3/plugins/github/bin/fetchAndPrintGithubRepo.js"
+    fetchAndPrintGithubRepo: resolveApp(
+      "src/plugins/github/bin/fetchAndPrintGithubRepo.js"
     ),
-    createExampleRepoV3: resolveApp(
-      "src/v3/plugins/git/bin/createExampleRepo.js"
-    ),
-    loadAndPrintGitRepositoryV3: resolveApp(
-      "src/v3/plugins/git/bin/loadAndPrintRepository.js"
+    createExampleRepo: resolveApp("src/plugins/git/bin/createExampleRepo.js"),
+    loadAndPrintGitRepository: resolveApp(
+      "src/plugins/git/bin/loadAndPrintRepository.js"
     ),
   },
 };

config/travis.js

@@ -73,13 +73,13 @@ function makeTasks(mode /*: "BASIC" | "FULL" */) {
       deps: ["check-pretty"],
     },
     {
-      id: "fetchGithubRepoTestV3",
-      cmd: ["./src/v3/plugins/github/fetchGithubRepoTest.sh", "--no-build"],
+      id: "fetchGithubRepoTest",
+      cmd: ["./src/plugins/github/fetchGithubRepoTest.sh", "--no-build"],
       deps: ["backend-in-place"],
     },
     {
-      id: "loadRepositoryTestV3",
-      cmd: ["./src/v3/plugins/git/loadRepositoryTest.sh", "--no-build"],
+      id: "loadRepositoryTest",
+      cmd: ["./src/plugins/git/loadRepositoryTest.sh", "--no-build"],
       deps: ["backend-in-place"],
     },
   ];

src/cli/commands/load.js

@@ -12,8 +12,7 @@ import {
   sourcecredDirectoryFlag,
 } from "../common";
 
-const execDependencyGraph = require("../../../tools/execDependencyGraph")
-  .default;
+const execDependencyGraph = require("../../tools/execDependencyGraph").default;
 
 export default class PluginGraphCommand extends Command {
   static description = "load data required for SourceCred";

src/cli/commands/start.js

@@ -5,7 +5,7 @@ import chalk from "chalk";
 import fs from "fs";
 import {choosePort} from "react-dev-utils/WebpackDevServerUtils";
 
-import apiApp from "../../../v3/app/apiApp";
+import apiApp from "../../app/apiApp";
 import {sourcecredDirectoryFlag} from "../common";
 
 const DEFAULT_PORT = parseInt(process.env.PORT, 10) || 4000;

src/cli/sourcecred.js

@@ -1,5 +1,5 @@
 // @flow
-require("../../tools/entry");
+require("../tools/entry");
 require("@oclif/command")
   .run()
   .catch(require("@oclif/errors/handle"));

src/plugins/git/example/synchronizeToGithub.sh

@@ -24,7 +24,7 @@ synchronize() (
     submodule_flag="$1"  # --submodule | --no-submodule
     remote_url="$2"
     tmpdir="$(mktemp -d)"
-    node bin/createExampleRepoV3.js "${submodule_flag}" "${tmpdir}"
+    node bin/createExampleRepo.js "${submodule_flag}" "${tmpdir}"
     (
         cd "${tmpdir}"
         git remote add upstream "${remote_url}"

src/plugins/git/loadRepositoryTest.sh

@@ -2,7 +2,7 @@
 
 set -eu
 
-data_file=src/v3/plugins/git/example/example-git.json
+data_file=src/plugins/git/example/example-git.json
 
 usage() {
   printf 'usage: %s [-u|--updateSnapshot] [--help]\n' "$0"
@@ -18,8 +18,8 @@ usage() {
 
 fetch() {
   tmpdir="$(mktemp -d)"
-  node bin/createExampleRepoV3.js "${tmpdir}"
-  node bin/loadAndPrintGitRepositoryV3.js "${tmpdir}"
+  node bin/createExampleRepo.js "${tmpdir}"
+  node bin/loadAndPrintGitRepository.js "${tmpdir}"
   rm -rf "${tmpdir}"
 }
 

src/plugins/github/fetchGithubRepoTest.sh

@@ -2,7 +2,7 @@
 
 set -eu
 
-data_file=src/v3/plugins/github/example/example-github.json
+data_file=src//plugins/github/example/example-github.json
 
 usage() {
   printf 'usage: %s [-u|--updateSnapshot] [--[no-]build] [--help]\n' "$0"
@@ -24,7 +24,7 @@ fetch() {
     printf >&2 'to a 40-character hex string API token from GitHub.\n'
     return 1
   fi
-  node bin/fetchAndPrintGithubRepoV3.js \
+  node bin/fetchAndPrintGithubRepo.js \
     sourcecred example-github "${GITHUB_TOKEN}"
 }