status-im/sourcecred
2
0
Fork 0
mirror of https://github.com/status-im/sourcecred.git synced 2025-02-20 00:08:10 +00:00
Code Issues Projects Releases Wiki Activity

Fix GitHub rendering for posts without authors (#341)

Browse Source 
Our GitHub renderer tries to display the author name for a comments or
pull request reviews. However, as we've already discovered (#228), not
every GitHub post has an author available. This breaks attempts to demo
the v1 cred explorer on some interesting repos, e.g. ipfs/js-ipfs.

Since the v1 code is all deprecated, it's effectively a demo branch
pending a rewrite of the cred explorer to use the v3 graph. As such, I
didn't include unit tests.

Test plan:
Attempt to run the cred explorer on `ipfs/js-ipfs` prior to this PR.
Observe that it loudly fails. Attempt to run it after this PR, and
that it succeeds.
This commit is contained in:
Dandelion Mané 2018-06-05 10:21:09 -07:00 committed by GitHub
parent e092b32bca
commit 222c334027
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/v1/plugins/github/render.js
View File

@ -81,6 +81,13 @@ function num(x: IssueReference | PullRequestReference) {
function authors(authorable: {+authors: () => AuthorReference[]}) { function authors(authorable: {+authors: () => AuthorReference[]}) {
// TODO: modify to accomodate multi-authorship // TODO: modify to accomodate multi-authorship
const authorRefs = authorable.authors(); const authorRefs = authorable.authors();
const firstAuthor = authorRefs[0].get(); const firstAuthorRef = authorRefs[0];
return firstAuthor != null ? firstAuthor.login() : "[unknown]"; if (firstAuthorRef == null) {
return "[unknown]";
}
const firstAuthorNode = firstAuthorRef.get();
if (firstAuthorNode == null) {
return "[unknown]";
}
return firstAuthorNode.login();
} }